Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solve Broadcast cluster means that multiple machines will be called, which is not converted to injvm protocol at this time. #7365

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

xiaoheng1
Copy link
Contributor

What is the purpose of the change

solve Broadcast cluster means that multiple machines will be called, which is not converted to injvm protocol at this time.

see more detail from #6842

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

… be called,which is not converted to injvm protocol at this time.
@codecov-io
Copy link

codecov-io commented Mar 13, 2021

Codecov Report

Merging #7365 (64b3771) into master (a588723) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7365      +/-   ##
============================================
- Coverage     58.64%   58.62%   -0.02%     
+ Complexity      425      424       -1     
============================================
  Files          1043     1043              
  Lines         42482    42484       +2     
  Branches       6217     6218       +1     
============================================
- Hits          24914    24908       -6     
- Misses        14780    14791      +11     
+ Partials       2788     2785       -3     
Impacted Files Coverage Δ Complexity Δ
...apache/dubbo/common/constants/CommonConstants.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...apache/dubbo/rpc/protocol/injvm/InjvmProtocol.java 77.77% <0.00%> (-4.58%) 0.00 <0.00> (ø)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-6.90%) 0.00% <0.00%> (ø%)
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) 8.00% <0.00%> (-1.00%)
...dubbo/remoting/exchange/support/DefaultFuture.java 84.61% <0.00%> (-3.42%) 0.00% <0.00%> (ø%)
.../org/apache/dubbo/rpc/model/ServiceDescriptor.java 88.23% <0.00%> (-2.95%) 0.00% <0.00%> (ø%)
...he/dubbo/common/threadpool/ThreadlessExecutor.java 94.23% <0.00%> (-1.93%) 0.00% <0.00%> (ø%)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 86.66% <0.00%> (-1.91%) 16.00% <0.00%> (ø%)
...e/dubbo/remoting/transport/netty4/NettyClient.java 69.56% <0.00%> (-1.45%) 0.00% <0.00%> (ø%)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a588723...64b3771. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 4b1c5e6 into apache:master Apr 12, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants