Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache Class avoid PermGen space OOM #7374

Merged
merged 3 commits into from
Mar 16, 2021

Conversation

xiaoheng1
Copy link
Contributor

What is the purpose of the change

cache Class avoid PermGen space OOM

see more detail from #6742

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Mar 15, 2021

Codecov Report

Merging #7374 (6ecb758) into master (d009d0c) will decrease coverage by 0.03%.
The diff coverage is 64.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7374      +/-   ##
============================================
- Coverage     58.72%   58.69%   -0.04%     
+ Complexity      425      423       -2     
============================================
  Files          1043     1043              
  Lines         42471    42475       +4     
  Branches       6212     6215       +3     
============================================
- Hits          24942    24930      -12     
- Misses        14748    14761      +13     
- Partials       2781     2784       +3     
Impacted Files Coverage Δ Complexity Δ
...n/java/org/apache/dubbo/common/bytecode/Proxy.java 72.22% <64.00%> (ø) 0.00 <0.00> (ø)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) 0.00% <0.00%> (ø%)
...dubbo/remoting/exchange/support/DefaultFuture.java 84.61% <0.00%> (-3.42%) 0.00% <0.00%> (ø%)
...c/main/java/org/apache/dubbo/rpc/RpcException.java 80.00% <0.00%> (-3.34%) 0.00% <0.00%> (ø%)
.../dubbo/remoting/transport/netty4/NettyChannel.java 64.35% <0.00%> (-2.98%) 0.00% <0.00%> (ø%)
...e/dubbo/registry/integration/RegistryProtocol.java 58.49% <0.00%> (-2.84%) 0.00% <0.00%> (ø%)
...he/dubbo/common/threadpool/ThreadlessExecutor.java 94.23% <0.00%> (-1.93%) 0.00% <0.00%> (ø%)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 86.66% <0.00%> (-1.91%) 16.00% <0.00%> (ø%)
...e/dubbo/remoting/transport/netty4/NettyClient.java 69.56% <0.00%> (-1.45%) 0.00% <0.00%> (ø%)
...ubbo/metadata/store/redis/RedisMetadataReport.java 23.37% <0.00%> (-0.99%) 5.00% <0.00%> (-1.00%)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d009d0c...6ecb758. Read the comment docs.

@AlbumenJ AlbumenJ added the status/don’t-merge No plan to merge label Mar 16, 2021
@AlbumenJ
Copy link
Member

do not merge before check if usable

@AlbumenJ AlbumenJ added type/performance and removed status/don’t-merge No plan to merge labels Mar 16, 2021
@AlbumenJ AlbumenJ merged commit af0dcc1 into apache:master Mar 16, 2021
me0106 added a commit to me0106/dubbo that referenced this pull request Mar 17, 2021
[Optimization] cache Class avoid PermGen space OOM (apache#7374)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants