Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serialize class checker #7436

Merged
merged 7 commits into from
Mar 26, 2021
Merged

Conversation

AlbumenJ
Copy link
Member

What is the purpose of the change

default block some class in gerenic filter deserializing

@codecov-io
Copy link

codecov-io commented Mar 24, 2021

Codecov Report

Merging #7436 (ac3b302) into master (7dd6855) will decrease coverage by 0.07%.
The diff coverage is 78.87%.

❗ Current head ac3b302 differs from pull request most recent head 0e5fe72. Consider uploading reports for the commit 0e5fe72 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7436      +/-   ##
============================================
- Coverage     59.19%   59.11%   -0.08%     
- Complexity      458      503      +45     
============================================
  Files          1043     1074      +31     
  Lines         42509    43190     +681     
  Branches       6226     6300      +74     
============================================
+ Hits          25162    25533     +371     
- Misses        14564    14821     +257     
- Partials       2783     2836      +53     
Impacted Files Coverage Δ Complexity Δ
...apache/dubbo/common/constants/CommonConstants.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...ava/org/apache/dubbo/rpc/filter/GenericFilter.java 39.62% <25.00%> (-0.38%) 0.00 <0.00> (ø)
...ache/dubbo/common/utils/SerializeClassChecker.java 85.24% <85.24%> (ø) 0.00 <0.00> (?)
...e/dubbo/common/beanutil/JavaBeanSerializeUtil.java 80.86% <100.00%> (+0.06%) 0.00 <0.00> (ø)
.../java/org/apache/dubbo/common/utils/PojoUtils.java 73.36% <100.00%> (+0.07%) 0.00 <0.00> (ø)
...a/org/apache/dubbo/rpc/filter/AccessLogFilter.java 26.86% <0.00%> (-52.24%) 0.00% <0.00%> (ø%)
...va/org/apache/dubbo/rpc/support/AccessLogData.java 53.16% <0.00%> (-37.98%) 0.00% <0.00%> (ø%)
...bo/config/event/listener/LoggingEventListener.java 37.50% <0.00%> (-25.00%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/WrappedChannelHandler.java 43.47% <0.00%> (-23.92%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/all/AllChannelHandler.java 75.86% <0.00%> (-20.69%) 0.00% <0.00%> (ø%)
... and 87 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dd6855...0e5fe72. Read the comment docs.

@AlbumenJ AlbumenJ changed the title [WIP] Add serialize class checker Add serialize class checker Mar 25, 2021
Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chickenlj chickenlj merged commit 4d3a318 into apache:master Mar 26, 2021
@owen200008
Copy link
Contributor

owen200008 commented Aug 18, 2021

image

we use generic to call 1W/s with dubbo2.7.8,dubbo update to 2.7.12 the speed is 7000/s and the memory use is too large。
what is the purpose of the CLASS_ALLOW_LFU_CACHE?
if it is for speed use the cache,use softreference is good enough

@owen200008
Copy link
Contributor

owen200008 commented Aug 18, 2021

  1. first i will add the switch
    later, i want change this like,the function call frequently
  2. name not need to lower
  3. no use lock in this way(read more, write less),use map the key is Class, the max size is same with class space / n

vio-lin pushed a commit to vio-lin/incubator-dubbo that referenced this pull request Feb 22, 2023
vio-lin added a commit to vio-lin/incubator-dubbo that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants