Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the switch to open class check, default is true #8537

Merged

Conversation

owen200008
Copy link
Contributor

@owen200008 owen200008 commented Aug 18, 2021

What is the purpose of the change

add the switch to open class check, default is true

my case have this problem
#7436

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Aug 18, 2021

Codecov Report

Merging #8537 (012b3a3) into master (9c49efe) will decrease coverage by 0.24%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8537      +/-   ##
============================================
- Coverage     61.28%   61.04%   -0.25%     
+ Complexity      449      448       -1     
============================================
  Files          1096     1097       +1     
  Lines         44220    44405     +185     
  Branches       6444     6469      +25     
============================================
+ Hits          27100    27105       +5     
- Misses        14138    14320     +182     
+ Partials       2982     2980       -2     
Impacted Files Coverage Δ
...apache/dubbo/common/constants/CommonConstants.java 100.00% <ø> (ø)
...ache/dubbo/common/utils/SerializeClassChecker.java 83.07% <50.00%> (-2.17%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-13.80%) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 35.52% <0.00%> (-10.53%) ⬇️
.../dubbo/remoting/transport/netty4/NettyChannel.java 62.37% <0.00%> (-3.97%) ⬇️
...port/identifier/BaseServiceMetadataIdentifier.java 57.14% <0.00%> (-3.58%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 76.66% <0.00%> (-3.34%) ⬇️
...ubbo/registry/support/AbstractRegistryFactory.java 83.09% <0.00%> (-2.82%) ⬇️
...e/dubbo/remoting/transport/netty4/NettyClient.java 69.56% <0.00%> (-1.45%) ⬇️
...e/dubbo/registry/integration/RegistryProtocol.java 60.30% <0.00%> (-0.19%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c49efe...012b3a3. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 4420118 into apache:master Aug 23, 2021
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants