Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix RedisMetadataReport cluster password is null #7474

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

xiaoheng1
Copy link
Contributor

What is the purpose of the change

fix RedisMetadataReport cluster password is null and refactor code.

see more detail from #6715

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Mar 29, 2021

Codecov Report

Merging #7474 (45dde0b) into master (576b3ab) will decrease coverage by 0.09%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7474      +/-   ##
============================================
- Coverage     59.12%   59.02%   -0.10%     
- Complexity      456      502      +46     
============================================
  Files          1043     1079      +36     
  Lines         42516    43329     +813     
  Branches       6226     6317      +91     
============================================
+ Hits          25136    25574     +438     
- Misses        14593    14912     +319     
- Partials       2787     2843      +56     
Impacted Files Coverage Δ Complexity Δ
...ubbo/metadata/store/redis/RedisMetadataReport.java 24.35% <50.00%> (+0.98%) 5.00 <0.00> (ø)
...a/org/apache/dubbo/rpc/filter/AccessLogFilter.java 26.86% <0.00%> (-52.24%) 0.00% <0.00%> (ø%)
...va/org/apache/dubbo/rpc/support/AccessLogData.java 53.16% <0.00%> (-37.98%) 0.00% <0.00%> (ø%)
.../cluster/configurator/parser/model/ConfigItem.java 48.00% <0.00%> (-24.00%) 0.00% <0.00%> (ø%)
...dubbo/common/status/support/LoadStatusChecker.java 46.15% <0.00%> (-15.39%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/WrappedChannelHandler.java 43.47% <0.00%> (-15.22%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/all/AllChannelHandler.java 68.96% <0.00%> (-13.80%) 0.00% <0.00%> (ø%)
...ing/context/DubboBootstrapApplicationListener.java 89.47% <0.00%> (-10.53%) 0.00% <0.00%> (ø%)
...che/dubbo/remoting/transport/mina/MinaChannel.java 35.52% <0.00%> (-10.53%) 14.00% <0.00%> (-1.00%)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) 0.00% <0.00%> (ø%)
... and 101 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 576b3ab...45dde0b. Read the comment docs.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT.

@AlbumenJ AlbumenJ merged commit 6cb16f9 into apache:master Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants