Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-#7479] Optimize code for loop condition.(#7479) #7480

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

stonelion
Copy link
Contributor

What is the purpose of the change

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Mar 30, 2021

Codecov Report

Merging #7480 (1650598) into master (6cb16f9) will decrease coverage by 0.02%.
The diff coverage is 25.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7480      +/-   ##
============================================
- Coverage     59.34%   59.31%   -0.03%     
- Complexity      501      502       +1     
============================================
  Files          1079     1079              
  Lines         43329    43327       -2     
  Branches       6317     6316       -1     
============================================
- Hits          25713    25700      -13     
- Misses        14786    14795       +9     
- Partials       2830     2832       +2     
Impacted Files Coverage Δ Complexity Δ
.../dubbo/registry/integration/RegistryDirectory.java 76.51% <25.00%> (+0.84%) 0.00 <0.00> (ø)
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 76.92% <0.00%> (-15.39%) 0.00% <0.00%> (ø%)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-6.90%) 0.00% <0.00%> (ø%)
...e/dubbo/registry/integration/RegistryProtocol.java 58.09% <0.00%> (-2.86%) 0.00% <0.00%> (ø%)
.../dubbo/monitor/support/AbstractMonitorFactory.java 78.37% <0.00%> (-2.71%) 0.00% <0.00%> (ø%)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 86.66% <0.00%> (-1.91%) 16.00% <0.00%> (ø%)
...pache/dubbo/registry/support/FailbackRegistry.java 66.82% <0.00%> (-0.94%) 0.00% <0.00%> (ø%)
...n/java/org/apache/dubbo/common/utils/UrlUtils.java 74.14% <0.00%> (-0.35%) 0.00% <0.00%> (ø%)
...pache/dubbo/registry/support/AbstractRegistry.java 79.62% <0.00%> (+1.11%) 0.00% <0.00%> (ø%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cb16f9...1650598. Read the comment docs.

@stonelion
Copy link
Contributor Author

@AlbumenJ

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit 6071280 into apache:master Apr 8, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants