Fix method may be null, and NullPointerException will be thrown in MethodUtils(#7605) #7606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7606 +/- ##
============================================
- Coverage 59.11% 59.10% -0.01%
- Complexity 528 530 +2
============================================
Files 1076 1076
Lines 43443 43434 -9
Branches 6346 6348 +2
============================================
- Hits 25681 25673 -8
- Misses 14917 14926 +9
+ Partials 2845 2835 -10 Continue to review full report at Codecov.
|
AlbumenJ
reviewed
Apr 26, 2021
| @@ -276,6 +276,10 @@ static Method findMethod(Class type, String methodName, Class<?>... parameterTyp | |||
| Method method = findMethod(type, methodName, parameterTypes); | |||
| T value = null; | |||
|
|
|||
| if (method == null) { | |||
| throw new IllegalStateException("method is null"); | |||
There was a problem hiding this comment.
how about make log more friendly?
Signed-off-by: xingrufei <xingrufei@sogou-inc.com>
2 tasks
goodjava
pushed a commit
to WZD-MI/incubator-dubbo
that referenced
this pull request
May 6, 2021
…thodUtils (apache#7606) * Fix method may be null, and NullPointerException will be thrown in MethodUtils(apache#7605) * Update by review Signed-off-by: xingrufei <xingrufei@sogou-inc.com> Co-authored-by: xingrufei <xingrufei@sogou-inc.com>
AlbumenJ
added a commit
to AlbumenJ/dubbo
that referenced
this pull request
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix method may be null, and NullPointerException will be thrown in MethodUtils
In this issue(#7605 ),Method may be null, and NullPointerException will be thrown in MethodUtils, this pr is to fix this issue, to avoid throwing NullPointerException in MethodUtils, thanks
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.