Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the IllegalArgumentException generated by PojoUtils.realize in GenericFilter to RpcException #7643

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

xiaoheng1
Copy link
Contributor

What is the purpose of the change

Convert the IllegalArgumentException generated by PojoUtils.realize in GenericFilter to RpcException

see more detail from #7642

Brief changelog

Verifying this change

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

…oUtils.realize in GenericFilter to RpcException
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2021

Codecov Report

Merging #7643 (e4c759a) into master (f8e25ec) will decrease coverage by 0.00%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7643      +/-   ##
============================================
- Coverage     59.11%   59.11%   -0.01%     
  Complexity      528      528              
============================================
  Files          1076     1076              
  Lines         43443    43445       +2     
  Branches       6346     6351       +5     
============================================
  Hits          25681    25681              
- Misses        14917    14925       +8     
+ Partials       2845     2839       -6     
Impacted Files Coverage Δ Complexity Δ
...ava/org/apache/dubbo/rpc/filter/GenericFilter.java 41.07% <77.77%> (+1.44%) 0.00 <0.00> (ø)
...che/dubbo/remoting/transport/mina/MinaChannel.java 35.52% <0.00%> (-10.53%) 14.00% <0.00%> (-1.00%)
...o/remoting/transport/ChannelHandlerDispatcher.java 60.00% <0.00%> (-10.00%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-6.90%) 0.00% <0.00%> (ø%)
...a/org/apache/dubbo/event/GenericEventListener.java 88.88% <0.00%> (-5.56%) 0.00% <0.00%> (ø%)
...java/org/apache/dubbo/common/utils/FieldUtils.java 84.84% <0.00%> (-5.48%) 0.00% <0.00%> (ø%)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0.00%> (-5.27%) 0.00% <0.00%> (ø%)
...mmon/serialize/kryo/utils/AbstractKryoFactory.java 75.43% <0.00%> (-3.51%) 0.00% <0.00%> (ø%)
.../remoting/transport/netty4/NettyClientHandler.java 83.05% <0.00%> (-3.39%) 0.00% <0.00%> (ø%)
...e/dubbo/registry/integration/RegistryProtocol.java 57.94% <0.00%> (-2.81%) 0.00% <0.00%> (ø%)
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8e25ec...e4c759a. Read the comment docs.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit 8d5417d into apache:master Apr 29, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants