Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dubbo2.7.x does not register serviceNameMapping information with the registry by default. #7672

Merged
merged 1 commit into from
May 5, 2021

Conversation

xiaoheng1
Copy link
Contributor

What is the purpose of the change

dubbo2.7.x does not register serviceNameMapping information with the registry by default.

see more detail from #7670

Brief changelog

Verifying this change

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

Codecov Report

Merging #7672 (62dae40) into master (2201510) will decrease coverage by 0.03%.
The diff coverage is 28.57%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7672      +/-   ##
============================================
- Coverage     59.18%   59.14%   -0.04%     
  Complexity      529      529              
============================================
  Files          1076     1076              
  Lines         43465    43474       +9     
  Branches       6355     6356       +1     
============================================
- Hits          25726    25714      -12     
- Misses        14900    14917      +17     
- Partials       2839     2843       +4     
Impacted Files Coverage Δ Complexity Δ
...in/java/org/apache/dubbo/config/ServiceConfig.java 60.59% <28.57%> (-1.37%) 0.00 <0.00> (ø)
...tadata/DynamicConfigurationServiceNameMapping.java 47.36% <0.00%> (-36.85%) 0.00% <0.00%> (ø%)
...nfig/configcenter/nop/NopDynamicConfiguration.java 75.00% <0.00%> (-12.50%) 0.00% <0.00%> (ø%)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) 0.00% <0.00%> (ø%)
...c/main/java/org/apache/dubbo/rpc/RpcException.java 80.00% <0.00%> (-3.34%) 0.00% <0.00%> (ø%)
.../dubbo/remoting/transport/netty4/NettyChannel.java 61.38% <0.00%> (-2.98%) 0.00% <0.00%> (ø%)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 86.66% <0.00%> (-1.91%) 16.00% <0.00%> (ø%)
...apache/dubbo/common/extension/ExtensionLoader.java 78.17% <0.00%> (-0.23%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/all/AllChannelHandler.java 89.65% <0.00%> (ø) 0.00% <0.00%> (ø%)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 60.58% <0.00%> (+0.58%) 31.00% <0.00%> (ø%)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2201510...62dae40. Read the comment docs.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit 1bed062 into apache:master May 5, 2021
goodjava pushed a commit to WZD-MI/incubator-dubbo that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants