Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add testcase for DubboService#parameters to verify issue#3072 #8001

Merged
merged 1 commit into from Jun 8, 2021

Conversation

pinxiong
Copy link
Member

@pinxiong pinxiong commented Jun 7, 2021

What is the purpose of the change

see issue #3072

Brief changelog

Add testcase to make sure 2.7.x branch works well

Verifying this change

Add testcase to check DubboService#parameters

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chickenlj chickenlj merged commit 56367d5 into apache:master Jun 8, 2021
@AlbumenJ AlbumenJ added this to Pending Review in Unit test cases Improvement via automation Jun 9, 2021
@AlbumenJ AlbumenJ moved this from Pending Review to Finished in Unit test cases Improvement Jun 9, 2021
@pinxiong pinxiong deleted the issue#3072 branch June 16, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants