Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the ThreadPoolStatusCheckerTest test case #8023

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

xiaoheng1
Copy link
Contributor

What is the purpose of the change

Optimize the ThreadPoolStatusCheckerTest test case

see more detail from #8022

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2021

Codecov Report

Merging #8023 (106e9c8) into master (c8d176f) will increase coverage by 0.54%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8023      +/-   ##
============================================
+ Coverage     60.47%   61.02%   +0.54%     
- Complexity      456      490      +34     
============================================
  Files          1090     1090              
  Lines         43937    43951      +14     
  Branches       6420     6423       +3     
============================================
+ Hits          26571    26820     +249     
+ Misses        14402    14145     -257     
- Partials       2964     2986      +22     
Impacted Files Coverage Δ
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) ⬇️
...port/identifier/BaseServiceMetadataIdentifier.java 53.57% <0.00%> (-7.15%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-6.90%) ⬇️
...apache/dubbo/common/config/ConfigurationUtils.java 67.74% <0.00%> (-1.01%) ⬇️
...apache/dubbo/common/extension/ExtensionLoader.java 81.02% <0.00%> (-0.26%) ⬇️
.../apache/dubbo/config/bootstrap/DubboBootstrap.java 54.53% <0.00%> (-0.05%) ⬇️
...org/apache/dubbo/config/context/ConfigManager.java 81.28% <0.00%> (ø)
.../main/java/org/apache/dubbo/rpc/RpcInvocation.java 64.73% <0.00%> (ø)
...ache/dubbo/config/utils/ConfigValidationUtils.java 73.82% <0.00%> (ø)
...n/java/org/apache/dubbo/common/utils/NetUtils.java 69.30% <0.00%> (+0.33%) ⬆️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8d176f...106e9c8. Read the comment docs.

Copy link
Member

@BurningCN BurningCN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chickenlj chickenlj merged commit ade452f into apache:master Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants