Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a new method for getting the number of consumer service addresses… #8026

Conversation

hadley0828
Copy link

What is the purpose of the change

fix #8025

Brief changelog

Add getConsumerAddressNumInAllRegistries in ServiceCheckUtils

Verifying this change

before:
the Consumer Sevice Name's list is null
after:
image

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

Codecov Report

Merging #8026 (c99dbb6) into master (fd4f765) will increase coverage by 0.68%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8026      +/-   ##
============================================
+ Coverage     59.42%   60.11%   +0.68%     
+ Complexity      555      489      -66     
============================================
  Files          1086     1090       +4     
  Lines         43800    43916     +116     
  Branches       6391     6394       +3     
============================================
+ Hits          26030    26400     +370     
+ Misses        14900    14550     -350     
- Partials       2870     2966      +96     
Impacted Files Coverage Δ
...ache/dubbo/qos/command/util/ServiceCheckUtils.java 6.89% <0.00%> (-4.87%) ⬇️
...ookeeper/ZookeeperDynamicConfigurationFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...org/apache/dubbo/remoting/zookeeper/EventType.java 0.00% <0.00%> (-61.91%) ⬇️
...pport/zookeeper/ZookeeperDynamicConfiguration.java 0.00% <0.00%> (-60.00%) ⬇️
.../configcenter/support/zookeeper/CacheListener.java 0.00% <0.00%> (-57.58%) ⬇️
...a/org/apache/dubbo/rpc/filter/AccessLogFilter.java 28.35% <0.00%> (-50.75%) ⬇️
...fig/configcenter/TreePathDynamicConfiguration.java 31.42% <0.00%> (-45.72%) ⬇️
...va/org/apache/dubbo/rpc/support/AccessLogData.java 53.16% <0.00%> (-37.98%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0.00%> (-20.69%) ⬇️
.../dubbo/remoting/transport/MultiMessageHandler.java 80.00% <0.00%> (-20.00%) ⬇️
... and 149 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd4f765...c99dbb6. Read the comment docs.

@CrazyHZM CrazyHZM added this to the 2.7.15 milestone Sep 25, 2021
@CrazyHZM
Copy link
Member

@hadley0828
Are you still paying attention to this PR? Take a look at the comment above.

@hadley0828
Copy link
Author

hadley0828 commented Sep 25, 2021

@hadley0828
Are you still paying attention to this PR? Take a look at the comment above.

Yeah, I have just replied. Thank you for your time.

@CrazyHZM
Copy link
Member

I think you can provide qos capabilities:

  1. Query the consumer address Num of all registries,
  2. Query the corresponding consumer address Num according to the registries
    @hadley0828

@chickenlj chickenlj modified the milestones: 2.7.15, 2.7.16 Jan 12, 2022
@chickenlj chickenlj merged commit a5b1d17 into apache:master Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/waiting-for-feedback Need reporters to triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The method "getConsumerAddressNum" in ServiceCheckUtils doesn't check all registries
5 participants