Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ut telnet handler adapter test #8258

Merged
merged 2 commits into from
Jul 11, 2021

Conversation

dgzpg
Copy link
Contributor

@dgzpg dgzpg commented Jul 10, 2021

What is the purpose of the change

add test for TelnetHandlerAdapter
see more detail from #8257

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@dgzpg dgzpg changed the base branch from 3.0 to master July 10, 2021 10:46
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2021

Codecov Report

Merging #8258 (33997c0) into master (11e15f2) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8258      +/-   ##
============================================
+ Coverage     61.24%   61.28%   +0.04%     
  Complexity      489      489              
============================================
  Files          1090     1090              
  Lines         43963    43963              
  Branches       6420     6420              
============================================
+ Hits          26924    26944      +20     
+ Misses        14063    14049      -14     
+ Partials       2976     2970       -6     
Impacted Files Coverage Δ
...ubbo/registry/support/AbstractRegistryFactory.java 83.09% <0.00%> (-2.82%) ⬇️
...e/dubbo/remoting/transport/netty4/NettyClient.java 69.56% <0.00%> (-1.45%) ⬇️
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 72.61% <0.00%> (-1.20%) ⬇️
...ting/zookeeper/curator/CuratorZookeeperClient.java 68.96% <0.00%> (-1.15%) ⬇️
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 79.72% <0.00%> (-0.35%) ⬇️
.../dubbo/remoting/transport/netty4/NettyChannel.java 62.37% <0.00%> (+0.99%) ⬆️
...pache/dubbo/registry/support/AbstractRegistry.java 79.62% <0.00%> (+1.11%) ⬆️
...ng/transport/dispatcher/all/AllChannelHandler.java 96.55% <0.00%> (+6.89%) ⬆️
...o/remoting/transport/ChannelHandlerDispatcher.java 70.00% <0.00%> (+10.00%) ⬆️
.../remoting/telnet/support/TelnetHandlerAdapter.java 88.63% <0.00%> (+36.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11e15f2...33997c0. Read the comment docs.

@AlbumenJ
Copy link
Member

Thanks for your contributions. Please also pick these changes to 3.0 branch.

@AlbumenJ AlbumenJ merged commit 0c1a9c6 into apache:master Jul 11, 2021
@dgzpg
Copy link
Contributor Author

dgzpg commented Jul 11, 2021

Thanks for your contributions. Please also pick these changes to 3.0 branch.

OK! thx!

@dgzpg dgzpg deleted the ut_TelnetHandlerAdapterTest branch July 11, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants