Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify remote reference for remote url #8973

Merged
merged 5 commits into from Oct 2, 2021

Conversation

CrazyHZM
Copy link
Member

@CrazyHZM CrazyHZM commented Oct 1, 2021

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@CrazyHZM CrazyHZM added this to Pending Review in Unit test cases Improvement via automation Oct 1, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2021

Codecov Report

Merging #8973 (44fa9cb) into 3.0 (8c27837) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 44fa9cb differs from pull request most recent head b7d17a8. Consider uploading reports for the commit b7d17a8 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8973      +/-   ##
============================================
- Coverage     63.69%   63.67%   -0.03%     
  Complexity      314      314              
============================================
  Files          1183     1183              
  Lines         50270    50270              
  Branches       7525     7525              
============================================
- Hits          32021    32007      -14     
- Misses        14752    14764      +12     
- Partials       3497     3499       +2     
Impacted Files Coverage Δ
...apache/dubbo/rpc/cluster/support/ClusterUtils.java 100.00% <100.00%> (+15.38%) ⬆️
.../remoting/transport/netty4/NettyServerHandler.java 58.13% <0.00%> (-9.31%) ⬇️
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-5.67%) ⬇️
...ng/exchange/support/header/HeartbeatTimerTask.java 68.42% <0.00%> (-5.27%) ⬇️
...nt/metadata/ServiceInstanceMetadataCustomizer.java 91.42% <0.00%> (-2.86%) ⬇️
.../dubbo/remoting/transport/netty4/NettyChannel.java 63.36% <0.00%> (-1.99%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 78.18% <0.00%> (-1.46%) ⬇️
...vent/listener/ServiceInstancesChangedListener.java 77.11% <0.00%> (-1.28%) ⬇️
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 70.23% <0.00%> (-1.20%) ⬇️
...ting/zookeeper/curator/CuratorZookeeperClient.java 70.38% <0.00%> (-0.98%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c27837...b7d17a8. Read the comment docs.

@CrazyHZM CrazyHZM merged commit 403a989 into apache:3.0 Oct 2, 2021
Unit test cases Improvement automation moved this from Pending Review to Finished Oct 2, 2021
@CrazyHZM CrazyHZM deleted the 3.0_feature/ut_remote_url branch October 2, 2021 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants