Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize some code for DubboConfigEarlyRegistrationPostProcessor (#9397) #9414

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Optimize some code for DubboConfigEarlyRegistrationPostProcessor (#9397) #9414

merged 1 commit into from
Dec 16, 2021

Conversation

gitchenjh
Copy link
Contributor

@gitchenjh gitchenjh commented Dec 15, 2021

What is the purpose of the change

add cache for DubboConfigEarlyInitializationPostProcessor#hasRegisteredCommonAnnotationBeanPostProcessor(#9397)

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2021

Codecov Report

Merging #9414 (4b754b4) into master (9cfb1ae) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #9414      +/-   ##
============================================
+ Coverage     60.82%   60.88%   +0.05%     
- Complexity      445      449       +4     
============================================
  Files          1100     1100              
  Lines         44509    44513       +4     
  Branches       6475     6476       +1     
============================================
+ Hits          27073    27101      +28     
+ Misses        14466    14444      -22     
+ Partials       2970     2968       -2     
Impacted Files Coverage Δ
...fig/DubboConfigEarlyRegistrationPostProcessor.java 55.26% <100.00%> (+5.26%) ⬆️
...dubbo/remoting/exchange/support/DefaultFuture.java 88.28% <0.00%> (-5.41%) ⬇️
.../dubbo/remoting/transport/netty4/NettyChannel.java 64.35% <0.00%> (-1.99%) ⬇️
...ting/zookeeper/curator/CuratorZookeeperClient.java 67.79% <0.00%> (-1.13%) ⬇️
...ng/zookeeper/curator5/Curator5ZookeeperClient.java 51.97% <0.00%> (-1.13%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 78.88% <0.00%> (-0.75%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0.00%> (ø)
...apache/dubbo/common/extension/ExtensionLoader.java 81.31% <0.00%> (+0.21%) ⬆️
...ubbo/registry/support/AbstractRegistryFactory.java 83.09% <0.00%> (+2.81%) ⬆️
...he/dubbo/remoting/transport/netty/NettyServer.java 73.68% <0.00%> (+3.50%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cfb1ae...4b754b4. Read the comment docs.

@chickenlj chickenlj added this to the 2.7.15 milestone Dec 16, 2021
Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit 1296ff8 into apache:master Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants