Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0 Triple] Fix graceful shutdown not work #9938

Merged
merged 1 commit into from Apr 19, 2022

Conversation

guohao
Copy link
Contributor

@guohao guohao commented Apr 19, 2022

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2022

Codecov Report

Merging #9938 (317a053) into 3.0 (7c72487) will increase coverage by 0.00%.
The diff coverage is 81.81%.

@@            Coverage Diff            @@
##                3.0    #9938   +/-   ##
=========================================
  Coverage     65.70%   65.71%           
+ Complexity      319      296   -23     
=========================================
  Files          1213     1213           
  Lines         52949    52945    -4     
  Branches       8021     8019    -2     
=========================================
+ Hits          34792    34793    +1     
+ Misses        14367    14361    -6     
- Partials       3790     3791    +1     
Impacted Files Coverage Δ
...bbo/remoting/api/PortUnificationServerHandler.java 39.13% <66.66%> (-3.18%) ⬇️
...ache/dubbo/remoting/api/PortUnificationServer.java 81.94% <80.00%> (-0.25%) ⬇️
...o/rpc/protocol/tri/transport/GracefulShutdown.java 81.48% <100.00%> (-4.24%) ⬇️
...ian2/dubbo/AbstractHessian2FactoryInitializer.java 50.00% <0.00%> (-11.12%) ⬇️
...g/apache/dubbo/remoting/api/ConnectionHandler.java 45.45% <0.00%> (-9.10%) ⬇️
...bo/rpc/protocol/dubbo/DecodeableRpcInvocation.java 73.14% <0.00%> (-2.78%) ⬇️
...dubbo/rpc/cluster/directory/AbstractDirectory.java 80.39% <0.00%> (-1.97%) ⬇️
...bbo/common/resource/GlobalResourcesRepository.java 70.90% <0.00%> (-1.82%) ⬇️
...adata/store/zookeeper/ZookeeperMetadataReport.java 72.34% <0.00%> (-1.07%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c72487...317a053. Read the comment docs.

@guohao guohao merged commit f2eef48 into apache:3.0 Apr 19, 2022
guohao added a commit to guohao/dubbo that referenced this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants