Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

[EAGLE-2][EAGLE-24][EAGLE-50][EAGLE-52]Add eagle offline metric collection topology and do online balance partition based on the statistic metric #8

Merged
merged 4 commits into from
Dec 3, 2015
Merged

[EAGLE-2][EAGLE-24][EAGLE-50][EAGLE-52]Add eagle offline metric collection topology and do online balance partition based on the statistic metric #8

merged 4 commits into from
Dec 3, 2015

Conversation

sunlibin
Copy link
Contributor

No description provided.

@sunlibin sunlibin force-pushed the Eagle-Metric-And-Balance-Partition branch from 71533df to 1701056 Compare November 27, 2015 15:53
@haoch
Copy link
Member

haoch commented Nov 30, 2015

@sunlibin This pull request has conflict with master branch that must be resolved, please resolve firstly.

@sunlibin sunlibin force-pushed the Eagle-Metric-And-Balance-Partition branch from 1701056 to 9e2c4d5 Compare November 30, 2015 03:43
@sunlibin sunlibin force-pushed the Eagle-Metric-And-Balance-Partition branch from 9e2c4d5 to 68f007d Compare November 30, 2015 04:05
@sunlibin
Copy link
Contributor Author

@haoch, just fix the conflicts

@sunlibin sunlibin force-pushed the Eagle-Metric-And-Balance-Partition branch from 68f007d to 3de5cce Compare November 30, 2015 05:38
@sunlibin sunlibin force-pushed the Eagle-Metric-And-Balance-Partition branch 2 times, most recently from a5e3e2f to a924cce Compare December 1, 2015 14:29
@sunlibin sunlibin force-pushed the Eagle-Metric-And-Balance-Partition branch from a924cce to b11a223 Compare December 2, 2015 06:54
@haoch
Copy link
Member

haoch commented Dec 3, 2015

LGTM, need clean commit history

@asfgit asfgit merged commit b11a223 into apache:master Dec 3, 2015
asfgit pushed a commit that referenced this pull request Dec 3, 2015
@haoch
[EAGLE-2] Add eagle offline metric collection topology and do online …
3ee73e8 
…balance partition based on the statistic metric

JIRA: [EAGLE-2][EAGLE-24][EAGLE-50][EAGLE-52]
Author: sunlibin <abnersunlibin@gmail.com>

Closes #8 from sunlibin:Eagle-Metric-And-Balance-Partition
@haoch
Copy link
Member

haoch commented Dec 6, 2015

  1. The change here https://github.com/apache/incubator-eagle/blob/master/eagle-core/eagle-data-process/eagle-stream-process-api/src/main/java/org/apache/eagle/dataproc/impl/storm/kafka/KafkaSourcedSpoutScheme.java#L63 breaks the previous features
  2. Keep default implementation for kafka provider instead of forcing developer to declare schema

@sunlibin
Copy link
Contributor Author

sunlibin commented Dec 7, 2015

@haoch , I check the commit log, I didn't change KafkaSourcedSpoutScheme

@haoch
Copy link
Member

haoch commented Dec 7, 2015

@sunlibin I think the file was created for the work about user-based partition in Spout, wasn't it?

@haoch
Copy link
Member

haoch commented Dec 7, 2015

Just keep it, there is some other problem about the implementation like forcing developer to do too much work while using kafka and code in logic level is too complex, I am refactoring about it and will discuss in mailing list later, otherwise there maybe some conflict :-)

@sunlibin
Copy link
Contributor Author

sunlibin commented Dec 7, 2015

@haoch, I'm afraid not, by checking the commit, we can see the code exists in the initial commit

@haoch
Copy link
Member

haoch commented Dec 7, 2015

@sunlibin, thanks for the info. It doesn't matter. I will fix it :-)

garrettlish pushed a commit to garrettlish/incubator-eagle that referenced this pull request Apr 21, 2017
Merge pull request apache#8 from kshantaraman/master
1bf07e1 
Change release tag format
denglingang added a commit to denglingang/eagle that referenced this pull request Jun 9, 2017
@denglingang
refactor security app (apache#8)
332dd42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunlibin @haoch @asfgit