Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

[EAGLE-872] Transform counter metric to rate metric #783

Closed
wants to merge 6 commits into from

Conversation

r7raul1984
Copy link

  • Add transform bolt using counterToRateFunction in HadoopMetricMonitorApp's storm topology.

https://issues.apache.org/jira/browse/EAGLE-872

- Add transform bolt using counterToRateFunction in HadoopMetricMonitorApp's storm topology.

https://issues.apache.org/jira/browse/EAGLE-872
@haoch
Copy link
Member

haoch commented Feb 8, 2017

@r7raul1984 would you convert all counter metric to rate?

@r7raul1984
Copy link
Author

@haoch If metric name endswith "count" , it will be converted to rate.

@haoch
Copy link
Member

haoch commented Mar 17, 2017

@r7raul1984 how do you think expose CountMetricFilter as a parameter to choose which metric to convert as count, and the current hard-code behavior should only be some kind of default implementation?

@FunctionInterface
interface  CountMetricFilter extends Function<Map, Boolean>

DefaultCountMetricFilter = (metric) -> metric["metric"].endsWith("*.count")

r7raul1984 added 5 commits March 20, 2017 01:03
	eagle-hadoop-metric/src/main/java/org/apache/eagle/metric/HadoopMetricMonitorApp.java
	eagle-hadoop-metric/src/main/java/org/apache/eagle/metric/HadoopMetricMonitorApp.java
@haoch
Copy link
Member

haoch commented Mar 21, 2017

LGTM

@r7raul1984
Copy link
Author

@haoch Thanks. I will merge.

@asfgit asfgit closed this in 673a81e Mar 21, 2017
jhsenjaliya pushed a commit to jhsenjaliya/eagle that referenced this pull request Jul 12, 2017
- Add transform bolt using counterToRateFunction in HadoopMetricMonitorApp's storm topology.

https://issues.apache.org/jira/browse/EAGLE-872

Author: r7raul1984 <tangjijun@yhd.com>

Closes apache#783 from r7raul1984/EAGLE-872.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants