Skip to content

Commit

Permalink
Merge pull request #12022 from Zaynex/fix-themeriver
Browse files Browse the repository at this point in the history
fix(themeRiver): use layer key map rather then largestLayer #11948
  • Loading branch information
100pah committed Aug 5, 2020
2 parents 8d3291e + 65d726e commit ab3d9e4
Show file tree
Hide file tree
Showing 2 changed files with 175 additions and 27 deletions.
48 changes: 21 additions & 27 deletions src/chart/themeRiver/ThemeRiverSeries.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,52 +63,46 @@ var ThemeRiverSeries = SeriesModel.extend({
*/
fixData: function (data) {
var rawDataLength = data.length;
/**
* Make sure every layer data get the same keys.
* The value index tells which layer has visited.
* {
* 2014/01/01: -1
* }
*/
var timeValueKeys = {};

// grouped data by name
var groupResult = groupData(data, function (item) {
if (!timeValueKeys.hasOwnProperty(item[0])) {
timeValueKeys[item[0]] = -1;
}
return item[2];
});
var layData = [];
groupResult.buckets.each(function (items, key) {
layData.push({name: key, dataList: items});
});

var layerNum = layData.length;
var largestLayer = -1;
var index = -1;
for (var i = 0; i < layerNum; ++i) {
var len = layData[i].dataList.length;
if (len > largestLayer) {
largestLayer = len;
index = i;
}
}

for (var k = 0; k < layerNum; ++k) {
if (k === index) {
continue;
}
var name = layData[k].name;
for (var j = 0; j < largestLayer; ++j) {
var timeValue = layData[index].dataList[j][0];
var length = layData[k].dataList.length;
var keyIndex = -1;
for (var l = 0; l < length; ++l) {
var value = layData[k].dataList[l][0];
if (value === timeValue) {
keyIndex = l;
break;
}
}
if (keyIndex === -1) {
for (var j = 0; j < layData[k].dataList.length; ++j) {
var timeValue = layData[k].dataList[j][0];
timeValueKeys[timeValue] = k;
}

for (var timeValue in timeValueKeys) {
if (timeValueKeys.hasOwnProperty(timeValue) && timeValueKeys[timeValue] !== k) {
timeValueKeys[timeValue] = k;
data[rawDataLength] = [];
data[rawDataLength][0] = timeValue;
data[rawDataLength][1] = 0;
data[rawDataLength][2] = name;
rawDataLength++;

}
}

}
return data;
},
Expand Down Expand Up @@ -293,4 +287,4 @@ var ThemeRiverSeries = SeriesModel.extend({
}
});

export default ThemeRiverSeries;
export default ThemeRiverSeries;
154 changes: 154 additions & 0 deletions test/themeRiver3.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit ab3d9e4

Please sign in to comment.