feat(gauge): Add data index and series index for indexing the data #14688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! The pull request is marked to be |
pissang
requested changes
Apr 20, 2021
src/util/innerStore.ts
Outdated
|
|
||
| const setItemDataAndSeriesIndex = function (this: Element, child: Element): void { | ||
| const childECData = getECData(child); | ||
| const thisECData = getECData(this); |
There was a problem hiding this comment.
I think this context is wrong here. It's not the root element in setCommenECData
Use anonymous function in setCommonECData is fine. JS engine will handle it well and won't have a performance issue. Use a separate function with a specified this context will be easy to have the above issue.
pissang
approved these changes
Jul 15, 2021
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Clicking on the progress in the gauge chart you can get an event
Fixed issues
#14655
Details
Before: What was the problem?
After: How is it fixed in this PR?
Add data index and series index for indexing the data by element in gauge
Useful in tooltip
Usage
Are there any API changes?
Related test cases or examples to use the new APIs
NA.
Others
Merging options
Other information