Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix candlestick throw error when some series filtered by legend. #12027

Merged
merged 1 commit into from Jan 13, 2020

Conversation

100pah
Copy link
Member

@100pah 100pah commented Jan 13, 2020

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

fix candlestick throw error when some series filtered by legend.

Fixed issues

fix #11611

Details

Before: What was the problem?

Throw error. see the case in #11611 .

After: How is it fixed in this PR?

Fix it by null checking.
But it might not be a best way.
If intending to declare performRawSeries in handlers, only
stream-independent (specifically, data item independent) operations can be
performed. Because is a series is filtered, most of the tasks will not
be performed. A stream-dependent operation probably cause wrong biz logic.
Perhaps we should not provide a separate callback for this case instead
of providing the config performRawSeries. The stream-dependent operations
and stream-independent operations should better not be mixed.
It can be down in future version because some more tests and check are needed,
now that the deadline of 4.7.0 is coming.

Related test cases or examples to use the new APIs

test/stream-filter2.html.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

candlestick chart output error with version 4.1.0 above, worked with version 4.0.4 below
3 participants