Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tree): the symbols of image type do not display at the first rendering. close #12279. #12367

Merged
merged 5 commits into from Jun 22, 2020

Conversation

plainheart
Copy link
Member

@plainheart plainheart commented Apr 2, 2020

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixes #12279
Fixes #11860

Fixed issues

Details

Before: What was the problem?

The symbols of image type do not display at the first rendering. Please refer to #12279, #11860 for more details.

Incorrect View

After: How is it fixed in this PR?

Correct View

After creating the instance of SymbolClz, update its data immediately but not wait until the next update rendering if the type of symbol is image.

Related test cases

Refer to test/tree-image2.html for a test case.

@echarts-bot
Copy link

echarts-bot bot commented Apr 2, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@plainheart plainheart changed the title fix(tree): the symbols of image type do not display at the first rendering. close apache#12279. fix(tree): the symbols of image type do not display at the first rendering. close #12279. Apr 2, 2020
@pissang pissang added this to the 4.9.0 milestone Apr 4, 2020
src/chart/tree/TreeView.js Outdated Show resolved Hide resolved
src/chart/tree/TreeView.js Outdated Show resolved Hide resolved
@pissang
Copy link
Contributor

pissang commented Jun 22, 2020

Looks good

100pah
100pah approved these changes Jun 22, 2020
@pissang pissang merged commit 8631f27 into apache:master Jun 22, 2020
@echarts-bot
Copy link

echarts-bot bot commented Jun 22, 2020

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart deleted the fix-12279 branch Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants