Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pie): pie series render incorrectly after editing its data in DataView. close #12560. #12561

Merged
merged 6 commits into from
Aug 4, 2020

Conversation

plainheart
Copy link
Member

@plainheart plainheart commented May 4, 2020

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixed issues

Close #12560

Code to Reproduce:

  • case 1. Click the DataView tool at the top-right cornor, and delete the first line USA.
  • case 2. Delete the last line (but don't remove \n or just retain some spaces).

Details

Before:

image

image

After:

image

image

Usage

Related test cases or examples to use the new APIs

Refer to test/pie-dataView.html

@echarts-bot
Copy link

echarts-bot bot commented May 4, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@pissang pissang added this to the 4.9.0 milestone May 8, 2020
@pissang pissang merged commit 0d471fa into apache:master Aug 4, 2020
@echarts-bot
Copy link

echarts-bot bot commented Aug 4, 2020

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart deleted the fix-12560 branch May 2, 2021 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataview 编辑数据之后重新渲染出错
3 participants