Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: optimize test cases for visual regression test #15715

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Conversation

pissang
Copy link
Contributor

@pissang pissang commented Sep 14, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Optimize test cases from #15599 for visual regression testing tool. To ensure:

  1. It needs to reflect the objectives of the test on the screenshot. For example, the animation duration needs to be long so the screenshot will be the intermediate state instead of the final state. The final state can't reflect the animation process.
  2. Every test case needs to been added at the bottom. To avoid the changed layout make recorded interactions fail.
  3. Every test case should have a title to describe the feature to test.

@echarts-bot
Copy link

echarts-bot bot commented Sep 14, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang pissang merged commit 233d2a1 into master Sep 14, 2021
@pissang pissang deleted the fix-test branch September 14, 2021 02:27
@echarts-bot
Copy link

echarts-bot bot commented Sep 14, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants