Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(treemap): add scaleLimit option to limit the zooming #18304

Merged
merged 8 commits into from
Jun 11, 2024
Merged

feat(treemap): add scaleLimit option to limit the zooming #18304

merged 8 commits into from
Jun 11, 2024

Conversation

liuyizhou
Copy link

@liuyizhou liuyizhou commented Feb 23, 2023 •
edited by plainheart
Loading

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Add scaleLimit option to allow limiting the zooming in treemap.

Fixed issues

#14599

Details

Before: What was the problem?

We don't have any limitation for zooming in treemap.

After: How does it behave after the fixing?

Support scaleLimit in treemap series, as graph series, tree series, geo component did.

Like scaleLimit in geo

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc@a7ef4f8

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

treemap-scaleLimit.html

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Feb 23, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@liuyizhou
Copy link
Author

相似的PR：#17602

@liuyizhou liuyizhou marked this pull request as draft March 2, 2023 06:41
@liuyizhou
Copy link
Author

@Ovilia

@Ovilia
Copy link
Contributor

Ovilia commented Mar 9, 2023

@liuyizhou If this PR is ready for review, please click the "Ready for review" button below. Otherwise, we won't notice this. Thanks!

@liuyizhou liuyizhou marked this pull request as ready for review March 9, 2023 08:28
Ovilia
Ovilia requested changes Mar 28, 2023
View reviewed changes
src/chart/treemap/TreemapSeries.ts Outdated Show resolved Hide resolved
src/chart/treemap/TreemapView.ts Outdated Show resolved Hide resolved
@liuyizhou liuyizhou requested a review from Ovilia April 20, 2023 06:27
@dannishushu
Copy link

请问给treemap加scaleLimit最后有没有被merge进rc版本？

@dannishushu
Copy link

@liuyizhou

@Talar1997
Copy link

@liuyizhou @Ovilia What is the status of this feature? Is this still in developement or has it been merged?

Is there any workaround to limit zoom on treemap chart?

Ovilia
Ovilia approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply. I've tested with visual test and it functions well. Thanks for making this possible! :)

@Ovilia Ovilia added this to the 5.5.1 milestone Jun 11, 2024
@Ovilia Ovilia merged commit 4b2d52f into apache:master Jun 11, 2024
@echarts-bot ECharts Bot
Copy link

echarts-bot bot commented Jun 11, 2024

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Ovilia added a commit that referenced this pull request Jun 11, 2024
@Ovilia
test(treemap): update test case for #18304
7faa2e1
@Ovilia Ovilia mentioned this pull request Jun 11, 2024
Merged
8 tasks
Ovilia added a commit that referenced this pull request Jun 11, 2024
@Ovilia
test(treemap): record test visual action for #18304
0ee9498
@Ovilia Ovilia mentioned this pull request Jun 11, 2024
Closed
8 tasks
pissang added a commit that referenced this pull request Jun 17, 2024
@pissang
Merge pull request #20020 from apache/feat-treemap-test
0ab5f72 
test(treemap): update test case for #18304
@plainheart plainheart changed the title feat(treemap): add scaleLimit to limit the zooming. close #14599 feat(treemap): add new option scaleLimit to limit the zooming Jun 18, 2024
@plainheart plainheart changed the title feat(treemap): add new option scaleLimit to limit the zooming feat(treemap): add scaleLimit option to limit the zooming Jun 18, 2024
plainheart added a commit to apache/echarts-doc that referenced this pull request Jun 21, 2024
@plainheart
feat(treemap): add scaleLimit option for treemap series (apache/ech…
a7ef4f8 
…arts#18304)
@plainheart plainheart added PR: doc ready and removed PR: awaiting doc Document changes is required for this PR. labels Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannishushu dannishushu dannishushu left review comments

@Ovilia Ovilia Ovilia approved these changes

Assignees
No one assigned
Labels
PR: doc ready PR: first-time contributor size/M
Projects
None yet
Milestone
5.5.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@liuyizhou @Ovilia @dannishushu @Talar1997 @plainheart