Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(treemap): update test case for #18304 #20020

Merged
merged 2 commits into from
Jun 17, 2024
Merged

test(treemap): update test case for #18304 #20020

merged 2 commits into from
Jun 17, 2024

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Jun 11, 2024

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

A tiny test case changes for #18304.

Fixed issues

Details

Before: What was the problem?

#18304 added a new option scaleLimit to treemap. In the added test case, one of the demo doesn't contain this option.

After: How does it behave after the fixing?

Fix the test case and add visual test action record of it.

image

From the recorded action, we can see that scaleLimit is used when zooming out of the limit.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Jun 11, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@Ovilia Ovilia added this to the 5.5.1 milestone Jun 11, 2024
Copy link
Contributor

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20020@0ee9498

@pissang pissang merged commit 0ab5f72 into master Jun 17, 2024
2 checks passed
Copy link

echarts-bot bot commented Jun 17, 2024

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang deleted the feat-treemap-test branch June 17, 2024 12:42
@plainheart plainheart removed this from the 5.5.1 milestone Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants