Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDKManager JavaDoc and some code optimisation #121

Merged
merged 4 commits into from
Apr 17, 2024

Conversation

Alonexc
Copy link
Contributor

@Alonexc Alonexc commented Apr 17, 2024

Fixes #issue_id

Motivation

add SDKManager javadoc and optimisation code.

Modifications

add SDKManager javadoc and optimisation code.

Documentation

  • Does this pull request introduce a new feature? no

Copy link
Member

@Pil0tXia Pil0tXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Very detailed JavaDoc.

@Pil0tXia Pil0tXia changed the title SDKManager javadoc and optimisation. Add SDKManager JavaDoc and some code optimisation Apr 17, 2024
@Pil0tXia Pil0tXia merged commit b43812a into apache:main Apr 17, 2024
3 checks passed
@Alonexc Alonexc deleted the dev_03 branch April 18, 2024 01:48
SLSJL pushed a commit to SLSJL/eventmesh-dashboard that referenced this pull request Jun 3, 2024
* main: (32 commits)
  [ISSUE apache#144] Auto approve when dependabot's branch is changed by someone else (apache#145)
  chore(deps): bump gradle/gradle-build-action from 2 to 3 (apache#140)
  chore(deps): bump actions/setup-java from 3 to 4 (apache#139)
  [ISSUE apache#134] Deploy Meta, Event Store and Runtime test environments in CI (apache#135)
  [ISSUE apache#63] Function Manager and Health Service update (apache#98)
  chore(deps): bump org.apache.commons:commons-lang3 from 3.13.0 to 3.14.0 (apache#124)
  chore(deps): bump com.alibaba.fastjson2:fastjson2 from 2.0.40 to 2.0.49 (apache#125)
  chore(deps): bump org.springdoc:springdoc-openapi-ui from 1.7.0 to 1.8.0 (apache#127)
  [ISSUE apache#132] Make Maven Wrapper executable (apache#133)
  [ISSUE apache#130] Auto-approve Dependabot PR only and Disable PR up-to-date check (apache#131)
  [ISSUE apache#128] Use GitHub CLI `comment` to auto-merge a Dependabot PR (apache#129)
  [ISSUE apache#122] Enable auto-merge workflow of Dependabot (apache#123)
  chore(deps): bump webpack-dev-middleware in /eventmesh-dashboard-view (apache#117)
  Add SDKManager JavaDoc and some code optimisation (apache#121)
  [ISSUE apache#119] Introduce dependencies for a unified return front-end format (apache#120)
  chore(deps): bump spring-boot.version from 2.7.6 to 2.7.18 (apache#112)
  chore(deps): bump org.apache.rocketmq:rocketmq-client (apache#115)
  chore(deps): bump org.apache.maven.plugins:maven-surefire-plugin (apache#111)
  chore(deps): bump org.apache.maven.plugins:maven-compiler-plugin (apache#114)
  chore(deps): bump io.etcd:jetcd-core from 0.7.5 to 0.7.7 (apache#113)
  ...

# Conflicts:
#	eventmesh-dashboard-view/src/assets/icons/index.ts
#	eventmesh-dashboard-view/src/routes/RootLayout.tsx
#	eventmesh-dashboard-view/src/routes/cluster/topic/Topic.tsx
#	eventmesh-dashboard-view/src/routes/cluster/topic/stats/Stats.tsx
#	eventmesh-dashboard-view/src/routes/cluster/topic/stats/TopicCount.tsx
#	eventmesh-dashboard-view/src/routes/navigation/Navigation.tsx
#	eventmesh-dashboard-view/src/routes/topic/topic-list/TopicList.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants