Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Auto-approve Dependabot PR only and Disable PR up-to-date check #130

Closed
3 tasks done
Pil0tXia opened this issue Apr 18, 2024 · 0 comments · Fixed by #131
Closed
3 tasks done

[Feature] Auto-approve Dependabot PR only and Disable PR up-to-date check #130

Pil0tXia opened this issue Apr 18, 2024 · 0 comments · Fixed by #131

Comments

@Pil0tXia
Copy link
Member

Pil0tXia commented Apr 18, 2024

Search before asking

  • I had searched in the issues and found no similar issues.

Feature Request

This issue is a final work of #128.

It seems required_status_checks.strict: true never worked until now:

image

Better set it to false because as long as this branch doesn't have any conflicts, it doesn't make any sense to keep it up-to-date. This is because GitHub CI runs on the pull request's master branch forward commit by default.

I will disable it at https://github.com/apache/eventmesh later.


image

Alright, GitHub CLI comment doesn't work. I would fall back to give Dependabot PR a single Approval only. Sebsequent merging requires reviewers' operation.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Pil0tXia added a commit that referenced this issue Apr 18, 2024
…e check (#131)

* No need to force up-to-date

* Auto-approve only

* Remove the slash at the end of the homepage url in Repo GitHub desc
SLSJL pushed a commit to SLSJL/eventmesh-dashboard that referenced this issue Jun 3, 2024
* main: (32 commits)
  [ISSUE apache#144] Auto approve when dependabot's branch is changed by someone else (apache#145)
  chore(deps): bump gradle/gradle-build-action from 2 to 3 (apache#140)
  chore(deps): bump actions/setup-java from 3 to 4 (apache#139)
  [ISSUE apache#134] Deploy Meta, Event Store and Runtime test environments in CI (apache#135)
  [ISSUE apache#63] Function Manager and Health Service update (apache#98)
  chore(deps): bump org.apache.commons:commons-lang3 from 3.13.0 to 3.14.0 (apache#124)
  chore(deps): bump com.alibaba.fastjson2:fastjson2 from 2.0.40 to 2.0.49 (apache#125)
  chore(deps): bump org.springdoc:springdoc-openapi-ui from 1.7.0 to 1.8.0 (apache#127)
  [ISSUE apache#132] Make Maven Wrapper executable (apache#133)
  [ISSUE apache#130] Auto-approve Dependabot PR only and Disable PR up-to-date check (apache#131)
  [ISSUE apache#128] Use GitHub CLI `comment` to auto-merge a Dependabot PR (apache#129)
  [ISSUE apache#122] Enable auto-merge workflow of Dependabot (apache#123)
  chore(deps): bump webpack-dev-middleware in /eventmesh-dashboard-view (apache#117)
  Add SDKManager JavaDoc and some code optimisation (apache#121)
  [ISSUE apache#119] Introduce dependencies for a unified return front-end format (apache#120)
  chore(deps): bump spring-boot.version from 2.7.6 to 2.7.18 (apache#112)
  chore(deps): bump org.apache.rocketmq:rocketmq-client (apache#115)
  chore(deps): bump org.apache.maven.plugins:maven-surefire-plugin (apache#111)
  chore(deps): bump org.apache.maven.plugins:maven-compiler-plugin (apache#114)
  chore(deps): bump io.etcd:jetcd-core from 0.7.5 to 0.7.7 (apache#113)
  ...

# Conflicts:
#	eventmesh-dashboard-view/src/assets/icons/index.ts
#	eventmesh-dashboard-view/src/routes/RootLayout.tsx
#	eventmesh-dashboard-view/src/routes/cluster/topic/Topic.tsx
#	eventmesh-dashboard-view/src/routes/cluster/topic/stats/Stats.tsx
#	eventmesh-dashboard-view/src/routes/cluster/topic/stats/TopicCount.tsx
#	eventmesh-dashboard-view/src/routes/navigation/Navigation.tsx
#	eventmesh-dashboard-view/src/routes/topic/topic-list/TopicList.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant