Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Should not use bash to excute sh script with CRLF in it and mis-output #4398

Closed
3 tasks done
Pil0tXia opened this issue Aug 24, 2023 · 0 comments · Fixed by #4401
Closed
3 tasks done

[Bug] Should not use bash to excute sh script with CRLF in it and mis-output #4398

Pil0tXia opened this issue Aug 24, 2023 · 0 comments · Fixed by #4401
Labels
bug Something isn't working

Comments

@Pil0tXia
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar issues.

Environment

Linux

EventMesh version

master

What happened

CRLF in shell script instead of LF

image

misleading output

image

image

The scripts worked with bash after dos2unix. The No Such Process output was misleading.

Relevant issue: #4299

bash or sh

image

The scripts fail when using sh even though they are marked with !/bin/sh to run with sh.

How to reproduce

https://eventmesh.apache.org/zh/docs/next/instruction/runtime/

Debug logs

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@Pil0tXia Pil0tXia added the bug Something isn't working label Aug 24, 2023
@Pil0tXia Pil0tXia mentioned this issue Aug 24, 2023
Merged
mxsm pushed a commit that referenced this issue Aug 26, 2023
@Pil0tXia
[ISSUE #4398] Use bash to excute shell script and fix mis-output (#4401)
3678c23 
* fix: dos2unix shell scripts & remove shell gitignore

* fix: use bash instead of sh by default

* fix: Verify if the previous process terminated abnormally for stop.sh

* fix: Verify if the previous process terminated abnormally for start.sh and optimize output

* Optimize: Standardise shell syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #4398] Use bash to excute shell script and fix mis-output Pil0tXia/eventmesh
1 participant
@Pil0tXia