Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4398] Use bash to excute shell script and fix mis-output #4401

Merged
merged 5 commits into from Aug 26, 2023

Conversation

Pil0tXia
Copy link
Member

Fixes #4398.

Motivation

#4299 (comment)
#4398

Modifications

image

image

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #4401 (420c336) into master (fd1102a) will not change coverage.
Report is 5 commits behind head on master.
The diff coverage is n/a.

❗ Current head 420c336 differs from pull request most recent head 203931d. Consider uploading reports for the commit 203931d to get more accurate results

@@            Coverage Diff            @@
##             master    #4401   +/-   ##
=========================================
  Coverage     17.85%   17.85%           
  Complexity     1514     1514           
=========================================
  Files           602      602           
  Lines         25518    25518           
  Branches       2400     2400           
=========================================
  Hits           4555     4555           
  Misses        20524    20524           
  Partials        439      439           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mxsm mxsm merged commit 3678c23 into apache:master Aug 26, 2023
7 checks passed
@Pil0tXia Pil0tXia deleted the pil0txia_bug_4398 branch January 4, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Should not use bash to excute sh script with CRLF in it and mis-output
3 participants