Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Improve eventmesh-connector-lark #4598

Closed
3 tasks done
hhuang1231 opened this issue Dec 4, 2023 · 0 comments · Fixed by #4599
Closed
3 tasks done

[Enhancement] Improve eventmesh-connector-lark #4598

hhuang1231 opened this issue Dec 4, 2023 · 0 comments · Fixed by #4599
Labels
enhancement New feature or request

Comments

@hhuang1231
Copy link
Contributor

hhuang1231 commented Dec 4, 2023 •
edited
Loading

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

There are still many optimization aspects of eventmesh-connectot-feishu module.

Describe the solution you'd like

  1. fix [ISSUE #4420] Add Feishu Sink connector #4522 (comment)
  2. Rename the module to eventmesh-connector-lark
  3. Simple http calls are changed to use the sdk provided by lark
  4. Support sinking text and markdown text types
  5. Support @ user or everyone
  6. Provide documentation
  7. Prevent message retransmission
  1. 修复 [ISSUE #4420] Add Feishu Sink connector #4522 (comment)
  2. 将模块重命名为eventmesh-connector-lark
  3. 简单的http调用改为使用lark提供的sdk
  4. 支持下沉text和markdown的文本类型
  5. 支持@用户或者所有人
  6. 提供文档
  7. 防止消息重传

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@hhuang1231 hhuang1231 added the enhancement New feature or request label Dec 4, 2023
@hhuang1231 hhuang1231 changed the title [Enhancement] improve eventmesh-connector-lark [Enhancement] Improve eventmesh-connector-lark Dec 4, 2023
@hhuang1231 hhuang1231 mentioned this issue Dec 4, 2023
Merged
xwm1992 pushed a commit that referenced this issue Dec 10, 2023
@hhuang1231
[ISSUE #4598] Improve eventmesh-connector-lark (#4599)
1e533d1 
* refactor : v1

* feat : v2

* feat : v3

* style : improve naming

* style : improve naming

* style :

* fix : javadoc

* docs : split into README.md and README_CN.md

* fix : token will expire

* feat : sync and async

* fix :

* fix :

* fix : add verify in regularSink method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #4598] Improve eventmesh-connector-lark hhuang1231/eventmesh
1 participant
@hhuang1231