[ISSUE #4598] Improve eventmesh-connector-lark

[hhuang1231]

Fixes #4598 .

Motivation

Improve eventmesh-connector-feishu.

Modifications

See #4598 for details.

Output

Documentation

• Does this pull request introduce a new feature? (yes / no)
• If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
• If a feature is not applicable for documentation, explain why?
• If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

[codecov]

Codecov Report

Attention: 92 lines in your changes are missing coverage. Please review.

Comparison is base (ee9ee4c) 16.93% compared to head (fadb477) 17.26%.

Files	Patch %	Lines
...ventmesh/connector/lark/sink/ImServiceHandler.java	66.27%	50 Missing and 7 partials ⚠️
...nnector/lark/sink/connector/LarkSinkConnector.java	52.17%	19 Missing and 3 partials ⚠️
...onnector/lark/sink/config/SinkConnectorConfig.java	68.42%	4 Missing and 2 partials ⚠️
...tmesh/connector/lark/server/LarkConnectServer.java	0.00%	5 Missing ⚠️
...connector/lark/config/LarkConnectServerConfig.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #4599      +/-   ##
============================================
+ Coverage     16.93%   17.26%   +0.32%     
- Complexity     1708     1741      +33     
============================================
  Files           790      793       +3     
  Lines         29526    29725     +199     
  Branches       2550     2567      +17     
============================================
+ Hits           5001     5132     +131     
- Misses        24061    24118      +57     
- Partials        464      475      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[xwm1992]

I have question about why you change the module name from Feishu to lark ?

[hhuang1231]

I have question about why you change the module name from Feishu to lark ?

@xwm1992 I found that the dingding module was changed to dingtalk.So I think it is necessary to change Feishu to lark.

[xwm1992]

I have question about why you change the module name from Feishu to lark ?

@xwm1992 I found that the dingding module was changed to dingtalk.So I think it is necessary to change Feishu to lark.

DingDing was changed to DingTalk because the English name of the product itself is called DingTalk, and Feishu was changed to lark. I don’t know if it’s still a same product or an overseas version of Feishu. @hhuang1231

[hhuang1231]

DingDing was changed to DingTalk because the English name of the product itself is called DingTalk, and Feishu was changed to lark. I don’t know if it’s still a same product or an overseas version of Feishu

@xwm1992 If the overseas Lark account I registered is correct, then the incident can be successfully sinked after testing.

[Pil0tXia]

@hhuang1231

The Feishu document said that "Feishu and Lark are independent products operated by different entities under ByteDance company. Feishu accounts can only be used in the Feishu client, and the Feishu client only supports the use of Feishu accounts."

If you want to be compatible with both products, you may need to pay attention to the interoperability of the data.

[hhuang1231]

@Pil0tXia Yes, I registered accounts for lark and feishu, and after testing, they can sink events.

[hhuang1231]

@pandaapo PLAT, thank you!

[pandaapo]

Please resolve the conflict. @hhuang1231