Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add protocol exclusive fields filter for /v2/configuration endpoint #4834

Closed
3 tasks done
Pil0tXia opened this issue Apr 14, 2024 · 0 comments · Fixed by #4835
Closed
3 tasks done

[Feature] Add protocol exclusive fields filter for /v2/configuration endpoint #4834

Pil0tXia opened this issue Apr 14, 2024 · 0 comments · Fixed by #4835
Labels
feature

Comments

@Pil0tXia
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar issues.

Feature Request

Since EventMeshTCPConfiguration, EventMeshHTTPConfiguration and EventMeshGrpcConfiguration are subclasses of CommonConfiguration, their serialized JsonString would contain superclass fields, which enlarges the response body and brings in difficulty in getting CommonConfiguration fields.

Add a PropertyFilter to remove superclass fields from the JsonString of EventMeshTCPConfiguration, EventMeshHTTPConfiguration and EventMeshGrpcConfiguration, then add CommonConfiguration into the response body.

The actual version number will be returned after merging #4055.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@Pil0tXia Pil0tXia mentioned this issue Apr 14, 2024
Merged
Pil0tXia added a commit that referenced this issue Apr 29, 2024
@Pil0tXia
[ISSUE #4834] Add protocol exclusive fields filter for `/v2/configura…
70f9892 
…tion` endpoint (#4835)

* Extract commonConfiguration out of subclasses

* Add configs param

* Unify return position

* Catch more exceptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #4834] Add protocol exclusive fields filter for /v2/configuration endpoint Pil0tXia/eventmesh
1 participant
@Pil0tXia