Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3918]RequestMapping, UrlMappingPattern can apply some optimizing #3919

Merged
merged 2 commits into from
May 31, 2023

Conversation

pandaapo
Copy link
Member

Fixes #3918.

Motivation

See "Enhancement Request" in issue.

Modifications

See "Describe the solution you'd like" in issue.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@Alonexc
Copy link
Contributor

Alonexc commented May 15, 2023

please check checkstyle.

@pandaapo
Copy link
Member Author

please check checkstyle.

It seems not my responsibility.

@Alonexc
Copy link
Contributor

Alonexc commented May 16, 2023

Yes, it has been fixed.

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #3919 (ac5b969) into master (0ce8d57) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head ac5b969 differs from pull request most recent head 5fba851. Consider uploading reports for the commit 5fba851 to get more accurate results

@@            Coverage Diff            @@
##             master    #3919   +/-   ##
=========================================
  Coverage     14.24%   14.24%           
  Complexity     1320     1320           
=========================================
  Files           579      579           
  Lines         28967    28952   -15     
  Branches       2802     2802           
=========================================
  Hits           4125     4125           
+ Misses        24450    24435   -15     
  Partials        392      392           
Impacted Files Coverage Δ
.../eventmesh/admin/rocketmq/util/RequestMapping.java 0.00% <0.00%> (ø)
...entmesh/admin/rocketmq/util/UrlMappingPattern.java 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xwm1992 xwm1992 merged commit fb144bb into apache:master May 31, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] RequestMapping, UrlMappingPattern can apply some optimizing
4 participants