Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4694] Component initialization order adjustment, add resource constraints. #4693

Merged
merged 9 commits into from
Jan 18, 2024

Conversation

Alonexc
Copy link
Contributor

@Alonexc Alonexc commented Dec 29, 2023

…ponent initialization order rules and DNS.

Fixes #4694 .

Motivation

Component initialization order adjustment, add resource constraints.

Modifications

Component initialization order adjustment, add resource constraints.

Documentation

  • Does this pull request introduce a new feature? no

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (87ed40d) 17.38% compared to head (e13e82b) 17.55%.
Report is 33 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4693      +/-   ##
============================================
+ Coverage     17.38%   17.55%   +0.16%     
- Complexity     1757     1778      +21     
============================================
  Files           797      797              
  Lines         29776    29871      +95     
  Branches       2573     2582       +9     
============================================
+ Hits           5177     5243      +66     
- Misses        24121    24145      +24     
- Partials        478      483       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alonexc Alonexc changed the title Component initialization order adjustment, add resource constraints. [ISSUE 4694] Component initialization order adjustment, add resource constraints. Dec 29, 2023
@Alonexc Alonexc changed the title [ISSUE 4694] Component initialization order adjustment, add resource constraints. [ISSUE #4694] Component initialization order adjustment, add resource constraints. Dec 29, 2023
xwm1992
xwm1992 previously approved these changes Dec 29, 2023
@Pil0tXia
Copy link
Member

Pil0tXia commented Jan 9, 2024

May I ask that is this PR working in progress or ready for review?

xwm1992
xwm1992 previously approved these changes Jan 10, 2024
@Alonexc
Copy link
Contributor Author

Alonexc commented Jan 10, 2024

May I ask that is this PR working in progress or ready for review?

This pr is ready for review and has been tested with pr #4727. The image used at this stage is built on this basis.

@xwm1992 xwm1992 merged commit ad2a41c into apache:master Jan 18, 2024
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] operator needs to start each component in order, and the component CPU resource limit.
3 participants