Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4721] Use gradle-build-action for caching and build scan link promotion #4722

Merged
merged 1 commit into from Jan 6, 2024

Conversation

clayburn
Copy link
Contributor

@clayburn clayburn commented Jan 4, 2024

Fixes #4721.

Motivation

This is a follow on effort to the change in #4685. This change will both show build scan links on GitHub Actions workflows and replace custom caching logic in the CI workflow.

Modifications

Documentation

  • Does this pull request introduce a new feature? (no)

@xwm1992 xwm1992 changed the title [Issue #4721] Use gradle-build-action for caching and build scan link promotion [ISSUE #4721] Use gradle-build-action for caching and build scan link promotion Jan 5, 2024
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b3f5375) 17.44% compared to head (38c5427) 17.46%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4722      +/-   ##
============================================
+ Coverage     17.44%   17.46%   +0.02%     
- Complexity     1768     1769       +1     
============================================
  Files           797      797              
  Lines         29845    29856      +11     
  Branches       2563     2579      +16     
============================================
+ Hits           5206     5214       +8     
- Misses        24159    24162       +3     
  Partials        480      480              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Pil0tXia Pil0tXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Pil0tXia added a commit to Pil0tXia/eventmesh-dashboard that referenced this pull request Jan 5, 2024
Copy link
Contributor

@pandaapo pandaapo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The modified Setup Gradle has a caching functionality similar to the original Cache Gradle packages, right?

@clayburn
Copy link
Contributor Author

clayburn commented Jan 5, 2024

The modified Setup Gradle has a caching functionality similar to the original Cache Gradle packages, right?

Yes, you can read about it in more detail here.

@mxsm mxsm merged commit c3326c0 into apache:master Jan 6, 2024
13 checks passed
Pil0tXia added a commit to apache/eventmesh-dashboard that referenced this pull request Jan 11, 2024
* Set up CI

* Add LICENSE

* Add CheckStyle

* Set up DB

* Add druid StatFilter controller

* sync CI change in apache/eventmesh#4722

* fix(*)1. 完成项目设计 2. 完成项目与模块搭建

* Supplement module dependency relation and fix project info

* Move original Admin into Core & rewrite dependencies

---------

Co-authored-by: laohu <2732554140@qq.com>
Pil0tXia added a commit to apache/eventmesh-dashboard that referenced this pull request Jan 16, 2024
* Set up CI

* Add LICENSE

* Add CheckStyle

* Set up DB

* Add druid StatFilter controller

* sync CI change in apache/eventmesh#4722

* Supplement module dependency relation and fix project info

* Move original Admin into Core & rewrite dependencies

* Rename package to .core

* Add .asf.yaml

* Enable branches with namespace triggering CI

* Set up Maven CI

* Downgrade JDK from 17 to 8

* Remove failed empty test

* Remove failed dependabot task

* Unify version number (using maven 3.8.1, maven wrapper to be added)

---------

Co-authored-by: laohu <2732554140@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Use gradle-build-action for caching and build scan link promotion
5 participants