Skip to content
This repository has been archived by the owner on Apr 4, 2021. It is now read-only.

FALCON-2033 ProcessRerun tests fail with User [falcon] not authorized for Coord job #193

Closed
wants to merge 1 commit into from

Conversation

bvellanki
Copy link
Contributor

No description provided.

@ying-eng
Copy link
Contributor

+1. Better to have a UT or IT for rerun. Could be a separate JIRA :)

@@ -1015,7 +1018,7 @@ private String getConsoleUrl(String cluster, String actionId) throws FalconExcep
// Get conf when workflow is launched.
if (coordinatorAction.getExternalId() != null) {
WorkflowJob jobInfo = client.getJobInfo(coordinatorAction.getExternalId());

workflowUser = jobInfo.getUser();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you look at AbstractRerunConsumer it's already taken care of

// Login the user to access WfEngine as this user
                CurrentUser.authenticate(message.getWorkflowUser());

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Does the message contain the correct workflow user?
From the log, the user for rerun used to be "falcon". Balu's change corrects it.

Copy link
Contributor Author

@bvellanki bvellanki Jun 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sowmyaramesh and @yzheng-hortonworks for raising valid points. From the logs reported by @muraliramasami , the rerun user is falcon when the coordinator (thus the workflow) were by user "hrt_qa". So CurrentUser.authenticate(message.getWorkflowUser()) is supposed to work and run re-run as message.getWorkflowUser(), but it is not accurate anymore. Let me debug some more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bvellanki : Can you please verify what message.getWorkflowUser() is if falcon entity is scheduled as a different user than falcon?

If it's falcon then fix you provided should be moved here so that it can handle multiple WF engines : say FalconWorkflowEngine, OozieWorkflowEngine and any other engine supported in future.

@bvellanki
Copy link
Contributor Author

This error was not reproducible in multiple falcon clusters. It is only seen in a specific test cluster, hence we suspect this to be environment issue and closing the Jira. Will reopen if it can be reproduced.

@bvellanki bvellanki closed this Jun 30, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants