FALCON-2231 Changes to support Schedule of user extensions #334

sandeepSamudrala · 2017-01-02T11:38:05Z

No description provided.

…me with Delay.

…-2231

sandeepSamudrala · 2017-01-02T11:44:16Z

I have dev-tested the same for submit and then scheduling it.

PracheerAgarwal-zz · 2017-01-02T11:47:02Z

prism/src/main/java/org/apache/falcon/resource/proxy/ExtensionManagerProxy.java

+        if (extensionJobsBean == null) {
+            // return failure if the extension job doesn't exist
+            return new APIResult(APIResult.Status.SUCCEEDED,
+                    "Extension job " + jobName + " doesn't exist. Nothing to delete.");


Nothing to delete/schedule?

Ack. Typos. I will correct it.

PracheerAgarwal-zz · 2017-01-02T11:51:14Z

unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java

+        try {
+            return localExtensionManager.scheduleExtensionJob(jobName, doAsUser);
+        } catch (FalconException | IOException e) {
+            throw new FalconCLIException("Failed to delete the extension job:" + jobName);


change the error msg to "failed to schedule the extension job"

PracheerAgarwal-zz · 2017-01-02T12:05:22Z

unit/src/main/java/org/apache/falcon/unit/LocalExtensionManager.java

@@ -88,7 +104,19 @@ public APIResult submitAndSchedulableExtensionJob(String extensionName, String j
        return new APIResult(APIResult.Status.SUCCEEDED, "Extension job submitted successfully" + jobName);


also change the returned message to "scheduled successfully".

Its submit api only.

may be I have commented at wrong place, but messages for both submit and submitAndSchedule was same.

Not related to this change. But I updated the return message for submitAndScheduleExtensionJob Api

thank you @sandeepSamudrala

… of extension not found while scheduling

pallavi-rao

Should we also make changes to ExtensionManager to ensure submit and submitSchedule of are not supported when issued against Falcon Sever, but, schedule is supported (will be scheduled on that colo alone).

pallavi-rao · 2017-01-03T05:57:32Z

unit/src/main/java/org/apache/falcon/unit/LocalExtensionManager.java

+    APIResult scheduleExtensionJob(String jobName, String doAsUser) throws  FalconException, IOException{
+        ExtensionMetaStore metaStore = ExtensionStore.getMetaStore();
+        ExtensionJobsBean extensionJobsBean = metaStore.getExtensionJobDetails(jobName);
+        SortedMap<EntityType, List<Entity>> entityMap = getJobEntities(extensionJobsBean);


Null check, if the extension job does not exist?

Not required its a map and the values are list.. which come as empty.

Not required as the map will have entries and the values are lists which will be empty

pallavi-rao · 2017-01-03T07:02:40Z

prism/src/main/java/org/apache/falcon/resource/proxy/ExtensionManagerProxy.java

-                // return failure if the extension job doesn't exist
-                return new APIResult(APIResult.Status.FAILED, "Extension job " + jobName + " doesn't exist.");
-            }
+        ExtensionMetaStore metaStore = ExtensionStore.getMetaStore();


The following lines of code, up until getJobEntities, I believe will be repeated for schedule, delete, suspend and resume. See if you can create a common method. I'm fine even if you do that when you implement suspend/resume.

I will be updating the same with the suspend/resume patch.

… submission and colo addition to schedule command

pallavi-rao

👍

PracheerAgarwal-zz · 2017-01-03T12:33:39Z

+1

PraveenAdlakha · 2017-01-03T15:43:56Z

+1

PraveenAdlakha · 2017-01-03T15:44:18Z

merging in some time.

@pallavi

Author: sandeep <sandysmdl@gmail.com> Reviewers: @pallavi,@pracheer,@praveen Closes apache#334 from sandeepSamudrala/FALCON-2231 and squashes the following commits: d32bf98 [sandeep] FALCON-2231 Fixed checkstyle issues. 2bbd7e2 [sandeep] FALCON-2231 Incoporated review comments and fixed test cases 2269806 [sandeep] FALCON-2231 Incoporated review comments and small fixes for duplicate submission and colo addition to schedule command 44d6f2a [sandeep] FALCON-2231 Corrected message in LocalExtensionManager f165282 [sandeep] FALCON-2231 Updated Error messages and throwing out exception in case of extension not found while scheduling 96a9a1d [sandeep] FALCON-2231 Rebased my patch ca320e0 [sandeep] FACLON-2231 Changes to support Schedule of user extensions 53831ea [sandeep] Merge branch 'master' of https://github.com/apache/falcon into FALCON-2231 cc28658 [sandeep] Merge branch 'master' of https://github.com/apache/falcon 089b10d [sandeep] Merge branch 'master' of https://github.com/apache/falcon 456d4ee [sandeep] Merge branch 'master' of https://github.com/apache/falcon 0cf9af6 [sandeep] Merge branch 'master' of https://github.com/apache/falcon 4a2e23e [sandeep] Merge branch 'master' of https://github.com/apache/falcon b1546ed [sandeep] Merge branch 'master' of https://github.com/apache/falcon 0a433fb [sandeep] Merge branch 'master' of https://github.com/apache/falcon 194f36a [sandeep] Merge branch 'master' of https://github.com/apache/falcon e0ad358 [sandeep] Merge branch 'master' of https://github.com/apache/falcon f96a084 [sandeep] Merge branch 'master' of https://github.com/apache/falcon 9cf36e9 [sandeep] Merge branch 'master' of https://github.com/apache/falcon bbca081 [sandeep] Merge branch 'master' of https://github.com/apache/falcon 48f6afa [sandeep] Merge branch 'master' of https://github.com/apache/falcon 250cc46 [sandeep] Merge branch 'master' of https://github.com/apache/falcon d0393e9 [sandeep] Merge branch 'master' of https://github.com/apache/falcon a178805 [sandeep] Merge branch 'master' of https://github.com/apache/falcon d6dc8bf [sandeep] Merge branch 'master' of https://github.com/apache/falcon 1bb8d3c [sandeep] Merge branch 'master' of https://github.com/apache/falcon c065566 [sandeep] reverting last line changes made 1a4dcd2 [sandeep] rebased and resolved the conflicts from master 271318b [sandeep] FALCON-2097. Adding UT to the new method for getting next instance time with Delay. a94d4fe [sandeep] rebasing from master 9e68a57 [sandeep] FALCON-298. Feed update with replication delay creates holes

sandeepSamudrala added 26 commits July 25, 2016 12:06

FALCON-298. Feed update with replication delay creates holes

9e68a57

rebasing from master

a94d4fe

FALCON-2097. Adding UT to the new method for getting next instance ti…

271318b

…me with Delay.

rebased and resolved the conflicts from master

1a4dcd2

reverting last line changes made

c065566

Merge branch 'master' of https://github.com/apache/falcon

1bb8d3c

Merge branch 'master' of https://github.com/apache/falcon

d6dc8bf

Merge branch 'master' of https://github.com/apache/falcon

a178805

Merge branch 'master' of https://github.com/apache/falcon

d0393e9

Merge branch 'master' of https://github.com/apache/falcon

250cc46

Merge branch 'master' of https://github.com/apache/falcon

48f6afa

Merge branch 'master' of https://github.com/apache/falcon

bbca081

Merge branch 'master' of https://github.com/apache/falcon

9cf36e9

Merge branch 'master' of https://github.com/apache/falcon

f96a084

Merge branch 'master' of https://github.com/apache/falcon

e0ad358

Merge branch 'master' of https://github.com/apache/falcon

194f36a

Merge branch 'master' of https://github.com/apache/falcon

0a433fb

Merge branch 'master' of https://github.com/apache/falcon

b1546ed

Merge branch 'master' of https://github.com/apache/falcon

4a2e23e

Merge branch 'master' of https://github.com/apache/falcon

0cf9af6

Merge branch 'master' of https://github.com/apache/falcon

456d4ee

Merge branch 'master' of https://github.com/apache/falcon

089b10d

Merge branch 'master' of https://github.com/apache/falcon

cc28658

Merge branch 'master' of https://github.com/apache/falcon into FALCON…

53831ea

…-2231

FACLON-2231 Changes to support Schedule of user extensions

ca320e0

FALCON-2231 Rebased my patch

96a9a1d

PracheerAgarwal-zz reviewed Jan 2, 2017

View reviewed changes

sandeepSamudrala added 2 commits January 2, 2017 17:43

FALCON-2231 Updated Error messages and throwing out exception in case…

f165282

… of extension not found while scheduling

FALCON-2231 Corrected message in LocalExtensionManager

44d6f2a

pallavi-rao suggested changes Jan 3, 2017

View reviewed changes

sandeepSamudrala added 2 commits January 3, 2017 16:47

FALCON-2231 Incoporated review comments and small fixes for duplicate…

2269806

… submission and colo addition to schedule command

FALCON-2231 Incoporated review comments and fixed test cases

2bbd7e2

pallavi-rao approved these changes Jan 3, 2017

View reviewed changes

FALCON-2231 Fixed checkstyle issues.

d32bf98

asfgit closed this in 7c5822c Jan 3, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FALCON-2231 Changes to support Schedule of user extensions #334

FALCON-2231 Changes to support Schedule of user extensions #334

sandeepSamudrala commented Jan 2, 2017

sandeepSamudrala commented Jan 2, 2017

PracheerAgarwal-zz Jan 2, 2017

sandeepSamudrala Jan 2, 2017

PracheerAgarwal-zz Jan 2, 2017

PracheerAgarwal-zz Jan 2, 2017

sandeepSamudrala Jan 2, 2017

PracheerAgarwal-zz Jan 2, 2017

sandeepSamudrala Jan 2, 2017

PracheerAgarwal-zz Jan 2, 2017

pallavi-rao left a comment

pallavi-rao Jan 3, 2017

sandeepSamudrala Jan 3, 2017

sandeepSamudrala Jan 3, 2017

pallavi-rao Jan 3, 2017

sandeepSamudrala Jan 3, 2017

pallavi-rao left a comment

PracheerAgarwal-zz commented Jan 3, 2017

PraveenAdlakha commented Jan 3, 2017

PraveenAdlakha commented Jan 3, 2017

		@@ -88,7 +104,19 @@ public APIResult submitAndSchedulableExtensionJob(String extensionName, String j
		return new APIResult(APIResult.Status.SUCCEEDED, "Extension job submitted successfully" + jobName);

FALCON-2231 Changes to support Schedule of user extensions #334

FALCON-2231 Changes to support Schedule of user extensions #334

Conversation

sandeepSamudrala commented Jan 2, 2017

sandeepSamudrala commented Jan 2, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pallavi-rao left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pallavi-rao left a comment

Choose a reason for hiding this comment

PracheerAgarwal-zz commented Jan 3, 2017

PraveenAdlakha commented Jan 3, 2017

PraveenAdlakha commented Jan 3, 2017