FALCON-2274 Job list in extension #358

PracheerAgarwal-zz · 2017-02-07T11:04:50Z

No description provided.

PracheerAgarwal-zz · 2017-02-07T11:12:20Z

dev-tested
falcon extension -list
Hadoop is installed, adding hadoop classpath to falcon classpath
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/usr/local/falcon/falcon-distributed-0.11-SNAPSHOT/client/lib/slf4j-log4j12-1.7.5.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/usr/hdp/2.2.4.2-2/hadoop/lib/slf4j-log4j12-1.7.5.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
4
sampleAsc extension-example
sampleAsc2 extension-example

sandeepSamudrala

👍

pallavi-rao · 2017-02-08T03:12:57Z

prism/src/main/java/org/apache/falcon/resource/proxy/ExtensionManagerProxy.java

    @Produces({MediaType.TEXT_XML, MediaType.APPLICATION_JSON})
    public ExtensionJobList getExtensionJobs(
-            @PathParam("extension-name") String extensionName,
+            @QueryParam("extension-name") String extensionName,


Why query param? Path param is REST compliant and is in-line with other APIs too.

this API is used for two use case, one to get the jobs for an extension and other to get all jobs irrespective of registered extension.
In the second case, we were not passing anything in extension-name, means null.. which resulted in error from FalconClient that the given parameter is null. So I changed it to QueryParam.

Understand the intent. Can you see if we can do something like what we do for entity listing. Entity type is part of the path, but, is optional.

pallavi-rao · 2017-02-09T05:15:15Z

prism/src/main/java/org/apache/falcon/resource/proxy/ExtensionManagerProxy.java

    @Produces({MediaType.TEXT_XML, MediaType.APPLICATION_JSON})
    public ExtensionJobList getExtensionJobs(
            @PathParam("extension-name") String extensionName,
            @DefaultValue(ASCENDING_SORT_ORDER) @QueryParam("sortOrder") String sortOrder,
            @DefaultValue("") @QueryParam("doAs") String doAsUser) {
        checkIfExtensionServiceIsEnabled();
-        getExtensionIfExists(extensionName);
+        if (extensionName != null) {


Use StringUtils.isNotBlank instead.

pallavi-rao · 2017-02-09T05:51:34Z

prism/src/main/java/org/apache/falcon/resource/proxy/ExtensionManagerProxy.java

-        getExtensionIfExists(extensionName);
+        if (StringUtils.isNotBlank(extensionName)) {
+            getExtensionIfExists(extensionName);
+        }
        try {
            return super.getExtensionJobs(extensionName, sortOrder, doAsUser);


Do you also want to modify getExtensionJobs to use StringUtils.isNotBlank? Because now, extensionName will not be null.

smart catch. Ack.

pallavi-rao

👍

@sandeepSamudrala

Author: Pracheer Agarwal <pracheer.agarwal@inmobi.com> Author: Pracheer Agarwal <pracheeragarwal@gmail.com> Author: Pracheer Agarwal <pr@im2216-x0.corp.inmobi.com> Reviewers: @sandeepSamudrala,@pallavi-rao Closes #358 from PracheerAgarwal/FALCON-2274 and squashes the following commits: a5ac209 [Pracheer Agarwal] review comment changes 9abd11d [Pracheer Agarwal] review comment changes 53a49bd [Pracheer Agarwal] review comment changes 38f901e [Pracheer Agarwal] review comments changes 917d3d5 [Pracheer Agarwal] review comments changes e73e97d [Pracheer Agarwal] FALCON-2274 Job list in extension 0a9c51c [Pracheer Agarwal] FALCON-2274 Job list in extension ab1d136 [Pracheer Agarwal] FALCON-2274 Job list in extension ba60452 [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon ed65aa0 [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon 9ff05df [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon 9c2f0a5 [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon 9cd8c17 [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon 778c579 [Pracheer Agarwal] Merge branch 'master' of https://github.com/PracheerAgarwal/falcon e39808d [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon a932633 [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon fda3b28 [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon a93d71a [Pracheer Agarwal] Merge branch 'master' of https://github.com/PracheerAgarwal/falcon e3728d5 [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon 066c8e2 [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon b20f044 [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon 7f572a1 [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon 46042fd [Pracheer Agarwal] Merge branch 'master' of https://github.com/PracheerAgarwal/falcon daa3ffc [Pracheer Agarwal] FALCON-2225 extension owner added for trusted extensions 622cae4 [Pracheer Agarwal] FALCON-2225 extension owner added for trusted extensions (cherry picked from commit b23b0a9) Signed-off-by: Pallavi Rao <pallavi.rao@inmobi.com>

@sandeepSamudrala

Author: Pracheer Agarwal <pracheer.agarwal@inmobi.com> Author: Pracheer Agarwal <pracheeragarwal@gmail.com> Author: Pracheer Agarwal <pr@im2216-x0.corp.inmobi.com> Reviewers: @sandeepSamudrala,@pallavi-rao Closes apache#358 from PracheerAgarwal/FALCON-2274 and squashes the following commits: a5ac209 [Pracheer Agarwal] review comment changes 9abd11d [Pracheer Agarwal] review comment changes 53a49bd [Pracheer Agarwal] review comment changes 38f901e [Pracheer Agarwal] review comments changes 917d3d5 [Pracheer Agarwal] review comments changes e73e97d [Pracheer Agarwal] FALCON-2274 Job list in extension 0a9c51c [Pracheer Agarwal] FALCON-2274 Job list in extension ab1d136 [Pracheer Agarwal] FALCON-2274 Job list in extension ba60452 [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon ed65aa0 [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon 9ff05df [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon 9c2f0a5 [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon 9cd8c17 [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon 778c579 [Pracheer Agarwal] Merge branch 'master' of https://github.com/PracheerAgarwal/falcon e39808d [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon a932633 [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon fda3b28 [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon a93d71a [Pracheer Agarwal] Merge branch 'master' of https://github.com/PracheerAgarwal/falcon e3728d5 [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon 066c8e2 [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon b20f044 [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon 7f572a1 [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon 46042fd [Pracheer Agarwal] Merge branch 'master' of https://github.com/PracheerAgarwal/falcon daa3ffc [Pracheer Agarwal] FALCON-2225 extension owner added for trusted extensions 622cae4 [Pracheer Agarwal] FALCON-2225 extension owner added for trusted extensions

PracheerAgarwal-zz and others added 19 commits December 20, 2016 10:19

FALCON-2225 extension owner added for trusted extensions

622cae4

FALCON-2225 extension owner added for trusted extensions

daa3ffc

Merge branch 'master' of https://github.com/PracheerAgarwal/falcon

46042fd

Merge branch 'master' of https://github.com/apache/falcon

7f572a1

Merge branch 'master' of https://github.com/apache/falcon

b20f044

Merge branch 'master' of https://github.com/apache/falcon

066c8e2

Merge branch 'master' of https://github.com/apache/falcon

e3728d5

Merge branch 'master' of https://github.com/PracheerAgarwal/falcon

a93d71a

Merge branch 'master' of https://github.com/apache/falcon

fda3b28

Merge branch 'master' of https://github.com/apache/falcon

a932633

Merge branch 'master' of https://github.com/apache/falcon

e39808d

Merge branch 'master' of https://github.com/PracheerAgarwal/falcon

778c579

Merge branch 'master' of https://github.com/apache/falcon

9cd8c17

Merge branch 'master' of https://github.com/apache/falcon

9c2f0a5

Merge branch 'master' of https://github.com/apache/falcon

9ff05df

Merge branch 'master' of https://github.com/apache/falcon

ed65aa0

Merge branch 'master' of https://github.com/apache/falcon

ba60452

FALCON-2274 Job list in extension

ab1d136

FALCON-2274 Job list in extension

0a9c51c

sandeepSamudrala approved these changes Feb 7, 2017

View reviewed changes

FALCON-2274 Job list in extension

e73e97d

pallavi-rao suggested changes Feb 8, 2017

View reviewed changes

PracheerAgarwal-zz added 2 commits February 9, 2017 10:28

review comments changes

917d3d5

review comments changes

38f901e

pallavi-rao suggested changes Feb 9, 2017

View reviewed changes

review comment changes

53a49bd

pallavi-rao suggested changes Feb 9, 2017

View reviewed changes

PracheerAgarwal-zz added 2 commits February 9, 2017 11:22

review comment changes

9abd11d

review comment changes

a5ac209

pallavi-rao approved these changes Feb 9, 2017

View reviewed changes

asfgit closed this in b23b0a9 Feb 9, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FALCON-2274 Job list in extension #358

FALCON-2274 Job list in extension #358

PracheerAgarwal-zz commented Feb 7, 2017

PracheerAgarwal-zz commented Feb 7, 2017

sandeepSamudrala left a comment

pallavi-rao Feb 8, 2017

PracheerAgarwal-zz Feb 8, 2017

pallavi-rao Feb 8, 2017

pallavi-rao Feb 9, 2017

pallavi-rao Feb 9, 2017

PracheerAgarwal-zz Feb 9, 2017

pallavi-rao left a comment

FALCON-2274 Job list in extension #358

FALCON-2274 Job list in extension #358

Conversation

PracheerAgarwal-zz commented Feb 7, 2017

PracheerAgarwal-zz commented Feb 7, 2017

sandeepSamudrala left a comment

Choose a reason for hiding this comment

pallavi-rao Feb 8, 2017

Choose a reason for hiding this comment

PracheerAgarwal-zz Feb 8, 2017

Choose a reason for hiding this comment

pallavi-rao Feb 8, 2017

Choose a reason for hiding this comment

pallavi-rao Feb 9, 2017

Choose a reason for hiding this comment

pallavi-rao Feb 9, 2017

Choose a reason for hiding this comment

PracheerAgarwal-zz Feb 9, 2017

Choose a reason for hiding this comment

pallavi-rao left a comment

Choose a reason for hiding this comment