FELIX-6390 Refactor the default authentication mechanism of the webconsole to be a WebConsoleSecurityProvider2 #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webconsole to be a WebConsoleSecurityProvider2
|
In the interest of moving forward, would it be possible to get a review and ruling on this proposal? |
|
Felix Committers: I have not gotten any feedback on the proposal, so I'm asking again for a review and ruling on the proposal. If you want to say no then that would be better than just ignoring the proposal. I really need a resolution one way or the other. |
cziegeler
pushed a commit
that referenced
this pull request
Aug 28, 2023
webconsole to be a WebConsoleSecurityProvider2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For FELIX-6390
The use case is that a webconsole plugin needs to make http requests outside of the OsgiManager servlet to retrieve some information to display in the plugin UI. The goal is that the security checking of that other endpoint would perform the same security checks that would be needed to access the webconsole itself. Reusing the WebConsoleSecurityProvider service in both places would be ideal.
The proposal is to refactor the default "basic" authentication mechanism of the webconsole into a WebConsoleSecurityProvider class and expose it as a service. A very low service.ranking of this last resort security provider should ensure that any other WebConsoleSecurityProvider component that exists would be used instead.