Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FINERACT-821 Made changes to enforce ConstantName Checkstyle (3) #1010

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

thesmallstar
Copy link
Member

@thesmallstar thesmallstar commented Jun 8, 2020

If anyone is wondering if am I converting those 40char names manually in correct format-
No, I wrote a code which does that for me https://github.com/thesmallstar/CorrectMyconstant

I saw there are about 1000 variables which need to change and this PR changes about 30-40 of them :P Long way to go, but sure it will be a great change.

Copy link
Member

@vorburger vorburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vorburger vorburger merged commit dae424d into apache:develop Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants