FINERACT-821 Added and Enforced ModifierOrder Checkstyle #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesmallstar
changed the title
|
Please merge #1080 before this, it would be easier to deal with merge conflicts(if any). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer: https://issues.apache.org/jira/browse/FINERACT-821
I used the custom spotless code from: https://www.mail-archive.com/commits@geode.apache.org/msg17088.html
@vorburger I think you would love the idea to have the modifier order fixed by spotless as implemented in this, if not we can remove that feature :)