Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FINERACT-1043: Unable to create client due to invalid error message about required address field #1110

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

kiran-vsm
Copy link
Contributor

@kiran-vsm kiran-vsm commented Jun 25, 2020

FINERACT-1043

Description

Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide

Copy link
Member

@vorburger vorburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In an ideal world, an Integration Test (IT) for this would be great.. but I'll merge it anyway, perhaps you'd like to contribute an IT in a follow-up?

@vorburger vorburger merged commit d9911bd into apache:develop Jun 26, 2020
@vorburger vorburger mentioned this pull request Jun 26, 2020
6 tasks
@nikpawar89
Copy link
Member

this doesn't solve the issue. issue is still there.
Rather this change should be reverted.

@kiran-vsm
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants