Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FINERACT-1141: Backport FINERACT-1135 to 1.4.0 Error at Loan Repaymen… #1314

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

vidakovic
Copy link
Contributor

Description

Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide

@vidakovic
Copy link
Contributor Author

@francisguchie please have a look at this when you have a moment

@vidakovic
Copy link
Contributor Author

@francisguchie @vorburger @ptuomola could one of you please verify this PR if you have a moment and merge it if it's ok? Thanks.

@francisguchie
Copy link
Contributor

francisguchie commented Sep 4, 2020

@francisguchie @vorburger @ptuomola could one of you please verify this PR if you have a moment and merge it if it's ok? Thanks.

@vidakovic , i have looked at the changes made and they are ok to me.
and i do agree to to the merge as i recall there were users of 1.4 that complained about the SQL Group By error. (#1166)
This PR addresses the sql error and caters for 1.4 users who use mySQL 5.7 that demands full GROUP BY SQL statements

@vidakovic
Copy link
Contributor Author

@francisguchie thanks a ton for taking the time... @ptuomola @vorburger can one of you take over the merge please as per new rules for PR merges? Thanks again.

@edcable edcable merged commit ee99f30 into apache:1.4.0 Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants