FINERACT-1216: Add FineractClientTest for Fineract SDK REST Client (fix) #1432
Conversation
There was a problem hiding this comment.
Wait a second, then why was #1428 green?! That's super weird, no? (Or was it not?)
https://travis-ci.org/github/apache/fineract/branches says we're currently green on develop
Do you have a link to where the build broken how, so that we can understand what is going on here?
| @@ -27,7 +27,7 @@ | |||
| * | |||
| * @author Michael Vorburger.ch | |||
| */ | |||
| public class Calls { | |||
| public final class Calls { | |||
There was a problem hiding this comment.
This makes sense, because it's a utility class with a private constructor... (and I vaguely remember that we have a Checkstyle or ErrorProne or SpotBugs check to enforce this - just want to find out why builds don't show up as red - or where they do)
| @@ -26,7 +26,7 @@ | |||
| * | |||
| * @author Michael Vorburger.ch | |||
| */ | |||
| public class FineractClient { | |||
| public final class FineractClient { | |||
There was a problem hiding this comment.
.. but this shouldn't be required? Especially since in #1433 I'm making createService() a protected method, so this class should remain open (extends-ible).
| @@ -42,7 +42,7 @@ public static FineractClientBuilder builder() { | |||
| return apiClient.createService(serviceClass); | |||
| } | |||
|
|
|||
| public static class FineractClientBuilder { | |||
| public static final class FineractClientBuilder { | |||
There was a problem hiding this comment.
as above (I think); best to see failing build and check if all 3 or only 1st (I think) need to be fixed?
|
Already taken care of with #1447 |
@ptuomola @vorburger Could one of you quickly have a look at this and merge please? There are 2 small issues with Checkstyle that this PR fixes.
Builds are currently broken because of this one here.