Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FINERACT-1410: Fix feature broken by PR1960 #1967

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

fynmanoj
Copy link
Contributor

@fynmanoj fynmanoj commented Nov 8, 2021

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@fynmanoj
Copy link
Contributor Author

fynmanoj commented Nov 8, 2021

@ptuomola, I had to override some changes you have pushed as it breaks the feature that is using the configurations. I understand that you have added these changes to fix the tests-execution issue.
I have added the same fix, without altering the migration scripts. Kindly look at this and approve if this looks OK to you.

@ptuomola
Copy link
Contributor

ptuomola commented Nov 8, 2021

Thanks @fynmanoj. I assumed that the original PR 1918 was intending to set this variable as false, as that's the value that was given for it in the class GlobalConfigurationHelper.java of PR1918.

If that was not the intention and this should have been true instead, then your PR looks good. I'll wait until the build passes and then will merge.

@fynmanoj
Copy link
Contributor Author

fynmanoj commented Nov 8, 2021

Yes, @ptuomola, The configuration is supposed to be enabled. Thanks

@ptuomola
Copy link
Contributor

ptuomola commented Nov 8, 2021

Build and tests passed - so good to merge! 👍

@ptuomola ptuomola merged commit eed1535 into apache:develop Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants