-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FINERACT-810 Upgrade Flyway version #676
Conversation
@awasum or @vorburger I need some help with this issue. |
@awasum and @vorburger, I don't know why MySQL 0.1 is the version used. |
I have been doing some research. |
unfortunately we cannot, due to licensing issues; look at my comment from June 11 in flyway/flyway#2332 which you found... in theory, the best way to get out of this impasse would probably be to contribute a fix to Flyway (an active project) or krummas/DrizzleJDBC#46 (dead project?). If we cannot do that (anyone reading this interested?), then perhaps we should just give up on this. |
I think the issue lies with the https://github.com/krummas/DrizzleJDBC and since it has been inactive for a while now we should just give up on it. |
The problem is that unfortunately we apparently can't use that other MySQL
JDBC driver, due to licensing issues (no LGPL at ASF).
|
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
That is true @percyashu, I already submited a patch for Drizzle in krummas/DrizzleJDBC#48. With this research I did other pull request in OpenJPA in apache/openjpa@26b1f6b which is now merged. With this patched version I was able to run fineract using even MySQL 8.0.12 |
Description
Upgrade Flyway to latest spring boot compatible version
https://issues.apache.org/jira/browse/FINERACT-810
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.
Integration tests have been created/updated for verifying the changes made.
All Integrations tests are passing with the new commits.
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide