Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FINERACT-810 Upgrade Flyway version #676

Closed
wants to merge 1 commit into from

Conversation

percyashu
Copy link
Contributor

@percyashu percyashu commented Dec 14, 2019

Description

Upgrade Flyway to latest spring boot compatible version
https://issues.apache.org/jira/browse/FINERACT-810

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide

@percyashu
Copy link
Contributor Author

@awasum or @vorburger I need some help with this issue.

@percyashu
Copy link
Contributor Author

@awasum and @vorburger, I don't know why MySQL 0.1 is the version used.
I found out that the upgraded Flyway does not support outdated MySQL 0.1 when using Drizzle driver and currently supports MySQL 5.1 and newer.

@percyashu
Copy link
Contributor Author

I have been doing some research.
I found out from flyway/flyway#2332 that Flyway support only the official MySQL driver.
Drizzle JDBC driver is incompatible with current Flyway version. I was thinking on changing the drizzle driver to MySQL connector or MariaDB ConnectorJ

@vorburger
Copy link
Member

I was thinking on changing the drizzle driver to MySQL connector or MariaDB ConnectorJ

unfortunately we cannot, due to licensing issues; look at my comment from June 11 in flyway/flyway#2332 which you found... in theory, the best way to get out of this impasse would probably be to contribute a fix to Flyway (an active project) or krummas/DrizzleJDBC#46 (dead project?).

If we cannot do that (anyone reading this interested?), then perhaps we should just give up on this.

@percyashu
Copy link
Contributor Author

the best way to get out of this impasse would probably be to contribute a fix to Flyway (an active project) or krummas/DrizzleJDBC#46 (dead project?).
If we cannot do that (anyone reading this interested?), then perhaps we should just give up on this.

I think the issue lies with the https://github.com/krummas/DrizzleJDBC and since it has been inactive for a while now we should just give up on it.

@vorburger
Copy link
Member

vorburger commented Jan 4, 2020 via email

@github-actions
Copy link

github-actions bot commented Feb 4, 2020

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

@github-actions github-actions bot added the stale label Feb 4, 2020
@github-actions github-actions bot closed this Mar 5, 2020
@nemux
Copy link
Contributor

nemux commented Apr 22, 2020

the best way to get out of this impasse would probably be to contribute a fix to Flyway (an active project) or krummas/DrizzleJDBC#46 (dead project?).
If we cannot do that (anyone reading this interested?), then perhaps we should just give up on this.

I think the issue lies with the https://github.com/krummas/DrizzleJDBC and since it has been inactive for a while now we should just give up on it.

That is true @percyashu, I already submited a patch for Drizzle in krummas/DrizzleJDBC#48.

With this research I did other pull request in OpenJPA in apache/openjpa@26b1f6b which is now merged.

With this patched version I was able to run fineract using even MySQL 8.0.12

imagen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants