Display git build info (FINERACT-883)

[xurror]

Display fineracts git build info actuator/info endpoint

Description

Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.

• Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.

• API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.

• Integration tests have been created/updated for verifying the changes made.

• All Integrations tests are passing with the new commits.

• Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)

Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide

[vorburger]

@xurror can you locally run and fix ./gradlew rat ? Some license header is missing.

BTW this has nothing to do with FINERACT-905, confusion.

PS please ignore the failed Build - Summary, and only look at Travis (see FINERACT-907).

[xurror]

PS please ignore the failed Build - Summary, and only look at Travis (see FINERACT-907).

Was wondering where it came from. Thanks for the notice

@xurror can you locally run and fix ./gradlew rat ? Some license header is missing.

Looking into it. It's kind of weird rat-report.txt is getting checked for license.

[xurror]

./gradlew rat passes locally.

[xurror]

Oh now this interesting. Seems .git directory cannot be found here since it is a file which is automatically ignored

This also fails with docker build.

[xurror]

It's hard for me to figure out how to pull this off.

I'm thinking to set the option failOnNoDotGitFound to false. @vorburger, @awasum do you think we can go with that.

[nikpawar89]

@xurror i saw the build, in your case following test case is failing:
org.apache.fineract.integrationtests.AccountingScenarioIntegrationTest > checkPeriodicAccrualAccountingFlow FAILED
java.lang.AssertionError at AccountingScenarioIntegrationTest.java:588

For now may be you want to ignore the the testcase . But definitely it is not a long time solution.
It appears to me a concurrency issue on Loan entity object and is not limited to integration tests.

[vorburger]

@xurror re. test failure, follow #782 to find FINERACT-899 and note #774, I think if you rebase this, that will disappear.

Oh now this interesting. Seems .git directory cannot be found here since it is a file which is automatically ignored

I don't think the .git/ is a file which is automatically ignored, but I suspect there are several situations where it's not present... this project certainly should still build even if there is no .git/ directory present. This could happen if someone builds from the Release ZIP, and a few other situations I can imagine...

I'm thinking to set the option failOnNoDotGitFound to false. @vorburger, @awasum do you think we can go with that.

... therefore something like that would probably be acceptable / good idea; see FINERACT-911.

However I do not find an option failOnNoDotGitFound so I suspect this was a typo?

[xurror]

@xurror re. test failure, follow #782 to find FINERACT-899 and note #774, I think if you rebase this, that will disappear.

Oh now this interesting. Seems .git directory cannot be found here since it is a file which is automatically ignored

I don't think the .git/ is a file which is automatically ignored, but I suspect there are several situations where it's not present... this project certainly should still build even if there is no .git/ directory present. This could happen if someone builds from the Release ZIP, and a few other situations I can imagine...

I'm thinking to set the option failOnNoDotGitFound to false. @vorburger, @awasum do you think we can go with that.

... therefore something like that would probably be acceptable / good idea; see FINERACT-911.

However I do not find an option failOnNoDotGitFound so I suspect this was a typo?

Oops, typo. It's failOnNoGitDirectory.

[xurror]

@vorburger, this passes now. Hope the you OK with the actual changes

[vorburger]

LGTM!