Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Policy re. unstable tests to README #782

Merged
merged 1 commit into from
Apr 26, 2020

Conversation

vorburger
Copy link
Member

@vorburger vorburger force-pushed the vorburger-README-flaky-tests branch 2 times, most recently from 695c728 to c857f36 Compare April 26, 2020 09:41
@vorburger
Copy link
Member Author

The latest "force push" just now just added @Ignore // TODO FINERACT-123 and Of course, we very much appreciate you then jumping onto any such bugs and helping us figure out how to fix all ignored tests!.

@awasum
Copy link
Contributor

awasum commented Apr 26, 2020

Why is the other Travis PR test failing?

I see this:

    java.lang.AssertionError at AccountingScenarioIntegrationTest.java:588```

Is this a flaky test? Something must be broken somewhere.

Copy link

@xurror xurror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that instead of having all this details stated out in one big paragraph, wouldn't it be better if the instructions were listed out in points form?. Reading a huge paragraph is kind of tedious and difficult to track. I have no problem with it though. Just think it would look better that way

@vorburger vorburger force-pushed the vorburger-README-flaky-tests branch from c857f36 to a39d132 Compare April 26, 2020 14:39
@vorburger
Copy link
Member Author

I suggest that instead of having all this details stated out in one big paragraph, wouldn't it be better if the instructions were listed out in points form?. Reading a huge paragraph is kind of tedious and difficult to track. I have no problem with it though. Just think it would look better that way

That is an excellent point, you are absolutely right, it was a bit "dense"... how about how it's now - better?

@xurror
Copy link

xurror commented Apr 26, 2020

I suggest that instead of having all this details stated out in one big paragraph, wouldn't it be better if the instructions were listed out in points form?. Reading a huge paragraph is kind of tedious and difficult to track. I have no problem with it though. Just think it would look better that way

That is an excellent point, you are absolutely right, it was a bit "dense"... how about how it's now - better?

Yeah, definitely. That looks more like it.

@nikpawar89
Copy link
Member

+1 from me.

@vorburger vorburger merged commit 09fd882 into develop Apr 26, 2020
@vorburger
Copy link
Member Author

I've exceptionally self merged this README only change PR based on the 2 votes of support expressed by @xurror and @nikpawar, because I have too much gray hear to re-re-base it following the successful build and merge of #785 and then wait for it to build and turn green...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants