Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executeAndAwaitJob() instead executeJob() in un-ignored FixedDepositTest [FINERACT-950] #959

Merged
merged 1 commit into from
Jun 3, 2020
Merged

executeAndAwaitJob() instead executeJob() in un-ignored FixedDepositTest [FINERACT-950] #959

merged 1 commit into from
Jun 3, 2020

Conversation

vorburger
Copy link
Member

@vorburger vorburger marked this pull request as draft June 1, 2020 13:49
@vorburger vorburger marked this pull request as ready for review June 1, 2020 19:53
@vorburger
Copy link
Member Author

/rebase

@vorburger
Copy link
Member Author

Build failure here is FINERACT-855 (has nothing to do with this PR for FINERACT-950).

@vorburger
Copy link
Member Author

This will have to be re-based after #968 for FINERACT-1016 for the build to pass.

@vorburger vorburger mentioned this pull request Jun 2, 2020
Merged
6 tasks
@vorburger
Copy link
Member Author

/rebase

@vorburger
Copy link
Member Author

@ptuomola @awasum @xurror does this one LGTY, merge?

xurror
xurror approved these changes Jun 2, 2020
View reviewed changes
Copy link

@xurror xurror left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine for me. I'll merge this in a few hours if there are no objections.

@vorburger vorburger mentioned this pull request Jun 2, 2020
Merged
@xurror xurror merged commit 0c6903f into apache:develop Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xurror xurror xurror approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vorburger @xurror